Skip to content

gazelle/julia: use upstream julia rules, no patched attr for consumers (part of #11418) - #12641

Merged
TrapsterDK merged 19 commits into
mainfrom
fix-11418-julia-package-name
Nov 15, 2026
Merged

TrapsterDK merged 19 commits into
mainfrom
fix-11418-julia-package-name

Conversation

@TrapsterDK

@TrapsterDK TrapsterDK commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

gazelle/julia/BUILD.bazel loads julia_binary/julia_test from @rules_julia directly, so consumers without patches/rules_julia:package_name.patch no longer fail analysis of stdlib_dump_upstream.

Part of #11418. Remaining: rules_cuda, rules_python, rules_go, rules_julia upstream patches/releases, protobuf consumer test.

Tests: //gazelle/julia:stdlib_test passes locally. Nested-Bazel and consumer tests not run.
Evidence: windows_x86_64 //tools/testing/hermetic:cpp_rust run 43660885365 green (dx_generate_check ok, Kotlin coverage green, qualified). Earlier run 43537493312 failed on a duplicate dx_licenses tag, since fixed. This branch also carries 12780 (merged) and 12703.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD

@TrapsterDK TrapsterDK added the needs-review Touches review paths; needs a second-session Review: comment label Nov 14, 2026
@TrapsterDK
TrapsterDK marked this pull request as ready for review November 14, 2026 01:01
@TrapsterDK
TrapsterDK marked this pull request as draft November 14, 2026 01:04
@TrapsterDK
TrapsterDK force-pushed the fix-11418-julia-package-name branch from 684cf8b to 522041b Compare November 14, 2026 01:25
@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Windows evidence for //tools/testing/hermetic:cpp_rust, run 43541761804 (test_timeout=3000): fails past analysis now. The consumer's rules_rust process_wrapper link fails with rust-lld 'could not open kernel32.lib' because the unpatched llvm module sets LIB=hermetic_llvm_empty_lib (patches/llvm/msvc_link_lib_env.patch is root-only). Needs a consumer-visible llvm patch (#11416). Stays draft.

@TrapsterDK
TrapsterDK force-pushed the fix-11418-julia-package-name branch from 522041b to cdef146 Compare November 14, 2026 03:20
@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Evidence run 43552270331 (windows_x86_64, //tools/testing/hermetic:cpp_rust, test_timeout=3000) now links and passes build/fetch/leak probes; fails at no_refetch: a restarted server refetched repositories (winsdk, host_platform, rules_java toolchains, rules_dx+). Previous run 43551159922 hit the 600s default timeout.

@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Root cause of the no_refetch failure in run 43552270331: every refetched repo is a local = True repository rule (bazel_tools winsdk_configure, platforms host_platform, rules_java local_jdk / compatibility_proxy / remote*_toolchain_config_repo, rules_android androidsdk, rules_cuda + rules_dx cuda configure, rules_py uv host) or the local_path_override of rules_dx itself (@@rules_dx+). Bazel documents that local = True repos are refetched on every server restart, so the probe added in #11476 (tools/testing/hermetic/src/lib.rs, no_refetch) cannot pass on any platform as written; it is not Windows-specific and not in anything this PR touches. Non-local repos (llvm, rules_rust, rules_python, ...) were not refetched.

Main never reaches this probe: main's linux, macOS and Windows hermetic jobs for //tools/testing/hermetic:cpp_rust fail earlier (fetch / hermetic_test) since #11476 landed (e.g. CI runs 43414090265, 43208363961).

Deciding how the guard should treat local repos (filter local_path_override modules as the nested harness does, and/or upstream local rules) is a guard change outside this PR's scope, so this PR stays draft pending that fix on main.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD

TrapsterDK and others added 2 commits November 14, 2026 06:29
…True repository rules (part of #11443)

The probe drops the modules the consumer overrides with local_path_override,
then asks `bazel mod show_repo --output=streamed_jsonproto` for the rule of
each remaining refetched repository and drops those whose repository_rule
declaration sets local = True. mod probes carry only common flags.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…h its own repository cache (part of #11443)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…ws 1024-character command line (part of #11443)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Rebased on main (clean, 12641 tests pass locally). Combo branch combo-11418-11443 (12641+12723+12703), //tools/testing/hermetic:cpp_rust:

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD

@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Status of the chain (12641 -> 12723 -> 12703), combo branch combo-11418-11443 rebased on main (windows_support conflict: reproducible_extensions.patch now applies after main's pins.patch and keys off the pinned values; lock regenerated with Bazel) plus #12753.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD

TrapsterDK and others added 6 commits November 14, 2026 23:57
…ules_kotlin patch (#9069)

kotlin_test passes the test class as kt_jvm_test main_class under Windows
coverage, so the -Dbazel.test_suite flag the rules_kotlin 2.4.21 launcher
appends names the test class. JACOCO_MAIN_CLASS still starts the dx runner.
Drop the root-only patches/rules_kotlin patch and its override.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
…age_name patch analyze (part of #11418)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…ense (part of #11418)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…hem (part of #11418)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…mer's repo name (part of #11418)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Rebased onto #12780 (fix-9069-kotlin-consumer-patch). Evidence run 43651406826 (cpp_rust, windows_x86_64) covers both. Merge #12780 first.

TrapsterDK and others added 3 commits November 15, 2026 00:32
…True repository rules (part of #11443)

The probe drops the modules the consumer overrides with local_path_override,
then asks `bazel mod show_repo --output=streamed_jsonproto` for the rule of
each remaining refetched repository and drops those whose repository_rule
declaration sets local = True. mod probes carry only common flags.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…h its own repository cache (part of #11443)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…ws 1024-character command line (part of #11443)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…s_julia patches (part of #11418)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Run 43651406826 (Windows cpp_rust): every probe passed, including fetch_coverage. The run failed only at the no_refetch check: "a restarted server refetched repositories" (local_config_winsdk, host_platform, local_jdk, ...). #12703 fixes that check. I stacked #12703's 3 commits, plus a unit-test fix that writes the rules_julia patches in the_consumer_materializes_from_dx_init (that test also fails on main), onto fix-11418-julia-package-name. Then I dispatched run 43653857809. The coverage probe, which covers Kotlin, runs after no_refetch, so it is still unverified.

TrapsterDK and others added 2 commits November 15, 2026 01:10
…aluates every extension (part of #11443)

The cpp_rust refetch_rules probe runs `bazel mod show_repo`, which evaluates
every module extension. protobuf 36.2's non-root crate.from_specs() has no
lockfile, so crate_universe failed (Windows run 43653857809). The composed
consumer MODULE.bazel now carries rules_dx's protobuf single_version_override
and its patch, as it does for rules_py and rules_flutter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
…aluates every extension (part of #11443)

The cpp_rust refetch_rules probe runs `bazel mod show_repo`, which evaluates
every module extension. protobuf 36.2's non-root crate.from_specs() has no
lockfile, so crate_universe failed (Windows run 43653857809). The composed
consumer MODULE.bazel now carries rules_dx's protobuf single_version_override
and its patch, as it does for rules_py and rules_flutter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
TrapsterDK and others added 3 commits November 15, 2026 01:56
…aterialize test writes rules_julia patches (part of #11443)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
…e-name

# Conflicts:
#	MODULE.bazel.lock
#	tools/testing/hermetic/src/tests.rs
@TrapsterDK
TrapsterDK marked this pull request as ready for review November 15, 2026 01:43
@TrapsterDK
TrapsterDK merged commit a8bb68c into main Nov 15, 2026
1 check failed
@TrapsterDK
TrapsterDK deleted the fix-11418-julia-package-name branch November 15, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Touches review paths; needs a second-session Review: comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant