Repository navigation
php, qt: read the MSVC redistributable from @dx_msvc_runtime (part of #11416) - #12799
Draft
TrapsterDK wants to merge 1 commit into
Draft
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
…me (part of #11416) Consumers get rules_dx's patched windows_support runtime instead of the unpatched BCR @msvc_runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php's Windows coverage runtime and qt's Windows cells read
vcruntime140.dllfrom@dx_msvc_runtime(rules_dx's patched windows_support) instead of the BCR@msvc_runtime, which consumers get unpatched.Part of #11416. Remaining:
//tools/testing/hermetic:cpp_rustonce gazelle/julia: use upstream julia rules, no patched attr for consumers (part of #11418) #12641 (gazelle/juliapackage_name) lands.@llvm//toolchain:bootstrap_stage) clang-cl toolchains still set theLIBplaceholder; needs the upstream hermetic-llvm fix.host_toolstag set after release.Tests:
//php/tests:version_test,//php/private/coverage:coverage_test,//php/tests/conformance:coverage_testpass on Linux.tools/dx check --affectedtimed out after 20 min (not checked). Nested-Bazel and consumer tests not run.Evidence (windows_x86_64): php 43663207667 pending, qt 43663217136 pending.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX