Repository navigation
rules_py: uv host repo reports glibc 2.28 without running ldd (part of #12482) - #12485
Merged
Merged
Conversation
TrapsterDK
force-pushed
the
fix-12482-uv-host-libc
branch
from
November 13, 2026 02:44
c4b6dbe to
cd30170
Compare
Collaborator
Author
|
Review: approve No must-fix items. The patch, MODULE.bazel override, RULES_PY_PATCHES, consumer data and README row are consistent. Two notes that do not block:
🤖 Generated with Claude Code |
This was referenced Nov 13, 2026
…#12482) The hermetic consumer has no ldd on PATH, so the rules_py uv host repo failed with "Unable to determine host libc!". Patch it to report the glibc 2.28 floor the cc toolchain targets, and pin the patch in the nested consumer override too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hygW8NyPkC1Ea1mT4L
TrapsterDK
force-pushed
the
fix-12482-uv-host-libc
branch
2 times, most recently
from
November 14, 2026 05:06
2979f17 to
b11a85b
Compare
TrapsterDK
marked this pull request as ready for review
November 14, 2026 05:27
This was referenced Nov 14, 2026
Merged
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12482
Change
patches/rules_py/host_libc_glibc.patch: on Linux,rules_py_uv_hostreportsglibc/2.28(the glibc floor of the hermetic cc toolchain) instead of runningldd --version, which is not on PATH in the hermetic consumer.MODULE.bazeloverride,RULES_PY_PATCHESintools/testing/nested/src/compose.rs, the harness/release consumer data andpatches/README.md.Tests
//patches:render_unit_test,//tools/testing/nested:dx_nested_test,//tools/testing/hermetic:hermetic_unit_testpass;@rules_py_uv_host//:defs.bzlfetches asglibc/2.28.//tools/testing/hermetic:cpp_rust,cpp_fixture_gcc,c_fixture_gccand other nested/consumer tests (CI only).tools/dx check --affectedtimed out on aspect errors in untouched packages (rust/tests/fixtures/native_call,ocaml/private/coverage,dotnet/private/fuzz,lua/private/coverage).Remaining
//patches:update_readme_testfails on main (fmt has no override in MODULE.bazel), untouched here.//tools/testing/hermetic:cpp_rust, combo of rules_py: uv host repo reports glibc 2.28 without running ldd (part of #12482) #12485 + hermetic: no_refetch ignores local_path_override modules and local = True repository rules (part of #11443) #12703 + gazelle/julia: use upstream julia rules, no patched attr for consumers (part of #11418) #12641 on main):fetchandfetch_coveragepass with noUnable to determine host libc; the run is red only in hermetic: no_refetch ignores local_path_override modules and local = True repository rules (part of #11443) #12703's newrefetch_rulesprobe (bazel modevaluates rules_python's publish pip extension offline).analysischeck: red on//rust/tests/fixtures/native_call:native_mixed_crt, a known main failure (also red on merged comments: delete indented # comments in cc, elixir, erlang, ocaml, capnproto .bzl (part of #11249) #12706, kotlin diagnostics test: use dx_testing::scratch_dir (part of #9216) #12702, docstrings: one-line docstrings in android, apple and swift .bzl (part of #11249) #12695).*_consumer_testtargets (CI only).lddhost libc probe.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hygW8NyPkC1Ea1mT4L