Skip to content

rules_py: uv host repo reports glibc 2.28 without running ldd (part of #12482) - #12485

Merged
TrapsterDK merged 1 commit into
mainfrom
fix-12482-uv-host-libc
Nov 14, 2026
Merged

TrapsterDK merged 1 commit into
mainfrom
fix-12482-uv-host-libc

Conversation

@TrapsterDK

@TrapsterDK TrapsterDK commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Part of #12482

Change

  • New patches/rules_py/host_libc_glibc.patch: on Linux, rules_py_uv_host reports glibc / 2.28 (the glibc floor of the hermetic cc toolchain) instead of running ldd --version, which is not on PATH in the hermetic consumer.
  • Wired into the root MODULE.bazel override, RULES_PY_PATCHES in tools/testing/nested/src/compose.rs, the harness/release consumer data and patches/README.md.

Tests

  • Local: //patches:render_unit_test, //tools/testing/nested:dx_nested_test, //tools/testing/hermetic:hermetic_unit_test pass; @rules_py_uv_host//:defs.bzl fetches as glibc/2.28.
  • Not run locally: //tools/testing/hermetic:cpp_rust, cpp_fixture_gcc, c_fixture_gcc and other nested/consumer tests (CI only). tools/dx check --affected timed out on aspect errors in untouched packages (rust/tests/fixtures/native_call, ocaml/private/coverage, dotnet/private/fuzz, lua/private/coverage).

Remaining

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hygW8NyPkC1Ea1mT4L

@TrapsterDK

Copy link
Copy Markdown
Collaborator Author

Review: approve

No must-fix items. The patch, MODULE.bazel override, RULES_PY_PATCHES, consumer data and README row are consistent. Two notes that do not block:

🤖 Generated with Claude Code

https://claude.ai/code/session_01Xut2hygW8NyPkC1Ea1mT4L

…#12482)

The hermetic consumer has no ldd on PATH, so the rules_py uv host repo
failed with "Unable to determine host libc!". Patch it to report the
glibc 2.28 floor the cc toolchain targets, and pin the patch in the
nested consumer override too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xut2hygW8NyPkC1Ea1mT4L
@TrapsterDK
TrapsterDK force-pushed the fix-12482-uv-host-libc branch 2 times, most recently from 2979f17 to b11a85b Compare November 14, 2026 05:06
@TrapsterDK
TrapsterDK marked this pull request as ready for review November 14, 2026 05:27
@TrapsterDK
TrapsterDK merged commit 76575a6 into main Nov 14, 2026
1 check failed
@TrapsterDK
TrapsterDK deleted the fix-12482-uv-host-libc branch November 14, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Touches review paths; needs a second-session Review: comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant