Repository navigation
kotlin: Windows kotlin_test coverage for consumers without the rules_kotlin patch (part of #9069) - #12780
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
Run 43651406826 (Windows cpp_rust): every probe passed, including fetch_coverage. The run failed only at the no_refetch check: "a restarted server refetched repositories" (local_config_winsdk, host_platform, local_jdk, ...). #12703 fixes that check. I stacked #12703's 3 commits, plus a unit-test fix that writes the rules_julia patches in the_consumer_materializes_from_dx_init (that test also fails on main), onto fix-11418-julia-package-name. Then I dispatched run 43653857809. The coverage probe, which covers Kotlin, runs after no_refetch, so it is still unverified. |
TrapsterDK
marked this pull request as ready for review
November 15, 2026 00:01
…ules_kotlin patch (#9069) kotlin_test passes the test class as kt_jvm_test main_class under Windows coverage, so the -Dbazel.test_suite flag the rules_kotlin 2.4.21 launcher appends names the test class. JACOCO_MAIN_CLASS still starts the dx runner. Drop the root-only patches/rules_kotlin patch and its override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
TrapsterDK
force-pushed
the
fix-9069-kotlin-consumer-patch
branch
from
November 15, 2026 01:40
ed5212a to
134cbe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9069
What changed
kotlin_test(kotlin/private/defs.bzl,kwargs.bzl) sets the upstreamkt_jvm_testmain_classto the test class under the new//kotlin/private:windows_coverageconfig_setting (Windows target +--collect_code_coverage), elseBazelTestRunner. The rules_kotlin 2.4.21 Windows launcher appends-Dbazel.test_suite=<main_class>, which now names the test class;JACOCO_MAIN_CLASSfromdx_jvm_test_coveragestill startsBazelTestRunner. This lives in rules_dx code, so consumers get it with no setup.patches/rules_kotlin/windows_coverage_test_suite.patch, itssingle_version_overrideinMODULE.bazeland thepatches/README.mdrow.MODULE.bazel.lockregenerated with Bazel.Tests
bazel test //kotlin/private:all //kotlin/tests/...pass;bazel coverage //kotlin/tests/fixtures/hello:hello_test //kotlin/tests/fixtures/hello:InferredTestpass.//tools/testing/hermetic:cpp_rust(windows_x86_64, combined with gazelle/julia: use upstream julia rules, no patched attr for consumers (part of #11418) #12641 and hermetic: no_refetch ignores local_path_override modules and local = True repository rules (part of #11443) #12703 on branch fix-11418-julia-package-name): not yet green. Runs 43651406826 and 43653857809 failed in the refetch check (hermetic: no_refetch ignores local_path_override modules and local = True repository rules (part of #11443) #12703's scope: run 43653857809refetch_rules_0exited 2 in therules_rustcrate_universeextension), before the Kotlin coverage probe ran. Kotlin Windows coverage is not yet shown by CI.Remaining for #9069
cpp_rustcoverage probe) once the hermetic: no_refetch ignores local_path_override modules and local = True repository rules (part of #11443) #12703 refetch check passes.windows_coverageselect.JACOCO_MAIN_CLASShook (and the select, since the launcher would then start the test class) and pointjvm_coverage_env_testat upstream.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX