Repository navigation
protobuf: bump to 37.0-rc3, drop no_crate_universe.patch (part of #11443) - #12723
Draft
TrapsterDK wants to merge 2 commits into
Draft
TrapsterDK wants to merge 2 commits into
TrapsterDK wants to merge 2 commits into
Conversation
) protobuf 37.0-rc3 pins its crate_universe call with a lockfile, so consumers' `bazel mod` evaluates it. grpc 1.85.1 gets a patch adding upb/reflection:reflection_cc next to upb/reflection for def.hpp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
TrapsterDK
added
the
needs-review
…tensions, harness re-record (part of #11443) - third_party/dotnet: Google.Protobuf 3.37.0-rc3 in paket.dependencies and paket.lock, deps regenerated with //dotnet:paket2bazel. - patches/windows_support/reproducible_extensions.patch: msvc_runtime and windows_sdk report reproducible when pinned, so MODULE.bazel.lock drops them; python budget lock_extensions 22 -> 20. - tools/testing/nested_cache: harness re-recorded with --config=nested_record. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
Collaborator
Author
|
Evidence: //tools/testing/hermetic:cpp_rust linux_x86_64 https://github.com/devhusdk/rules_dx/actions/runs/43568179584 |
Collaborator
Author
|
Evidence run 43568179584 failed before protobuf matters: consumer analysis of gazelle/julia uses the root-only package_name attr (rules_julia patch). Fixed by #12641; re-run cpp_rust evidence after it merges. |
Collaborator
Author
|
#12641 has landed on main, which fixes the julia package_name failure from run 43568179584. Rebase on main and re-run cpp_rust evidence before merging. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11443. #12703 rebases on this.
protobuf 36.2's non-root
crate.from_specs()has nolockfile, so a consumer'sbazel modfails it (the rules_dx patch only applies when rules_dx is root). 37.0-rc3 (BCR) addslockfile = "//rust:Cargo.Bazel.lock".Changes:
MODULE.bazel:protobuf37.0-rc3, no override;patches/protobufdeleted.patches/grpc/upb_reflection_cc.patch: grpc 1.85.1 targets onupb/reflectionalso depend onupb/reflection:reflection_cc(37.0 moveddef.hppthere).TESTED_PROTOBUF,bcr_newest.json, adopt preflight,proto_bindingsfixture,patches/README.md.third_party/dotnet:Google.Protobuf 3.37.0-rc3inpaket.dependenciesandpaket.lock;deps/paket.main.bzlregenerated withbazel run //dotnet:paket2bazel(sha512 checked against nuget.org). C# docs updated.patches/windows_support/reproducible_extensions.patch(owner decision ci: scheduled run is failing #9216):msvc_runtimeandwindows_sdkreturnreproducible = Truewhen their payloads are pinned by integrity, so the lock no longer records the//cc:extensions.bzland@windows_supportentries.python_budget.jsonlock_extensions22 -> 20.tools/testing/nested_cache/harness.txtand its lock re-recorded with--config=nested_record(linux_x86_64).MODULE.bazel.lockregenerated withbazel mod deps --lockfile_mode=update.Tests (linux_x86_64):
//core/modules/...(incl.versions_contract,python_budget_test),//patches/...,//third_party/dotnet/...,//cli/depcheck/...,//csharp/...,//dotnet/...,//gazelle/protobuf/...,//cli/adopt/...,//tools/testing:nested_bazel_harness_test(record mode).//patches:update_readme_test(main:fmt has no override in MODULE.bazel);//patches/llvm/tests:macos_sdk_symlinks_testfails on the linux host.Evidence:
//tools/testing/hermetic:cpp_rustlinux_x86_64 run 43568179584 red infetch_coverage:@@rules_dx+//gazelle/julia:stdlib_dump_upstream: no such attribute 'package_name' in 'julia_binary' rule(root-only rules_julia patch, not this change). Waits on #12641.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD