Repository navigation
hermetic: no_refetch ignores local_path_override modules and local = True repository rules (part of #11443) - #12703
TrapsterDK wants to merge 6 commits into
Conversation
33a29dc to
4fd055d
Compare
|
Evidence run 43560359806 (linux_x86_64, 🤖 Generated with Claude Code |
…True repository rules (part of #11443) The probe drops the modules the consumer overrides with local_path_override, then asks `bazel mod show_repo --output=streamed_jsonproto` for the rule of each remaining refetched repository and drops those whose repository_rule declaration sets local = True. mod probes carry only common flags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
…h its own repository cache (part of #11443) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
c279325 to
32e7862
Compare
|
Run 43560435796 (combo of this PR + #12485 + #12641) failed in 🤖 Generated with Claude Code |
|
Run 43561755161 (this PR + #12641, test_timeout=3000): the online 🤖 Generated with Claude Code |
|
Root cause of the protobuf 37.0-rc3 (BCR) and protobuf main add 🤖 Generated with Claude Code |
|
The protobuf 37.0-rc3 bump is in draft #12723 (drops 🤖 Generated with Claude Code |
…ws 1024-character command line (part of #11443) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD
|
Run 43651406826 (Windows cpp_rust): every probe passed, including fetch_coverage. The run failed only at the no_refetch check: "a restarted server refetched repositories" (local_config_winsdk, host_platform, local_jdk, ...). #12703 fixes that check. I stacked #12703's 3 commits, plus a unit-test fix that writes the rules_julia patches in the_consumer_materializes_from_dx_init (that test also fails on main), onto fix-11418-julia-package-name. Then I dispatched run 43653857809. The coverage probe, which covers Kotlin, runs after no_refetch, so it is still unverified. |
…aluates every extension (part of #11443) The cpp_rust refetch_rules probe runs `bazel mod show_repo`, which evaluates every module extension. protobuf 36.2's non-root crate.from_specs() has no lockfile, so crate_universe failed (Windows run 43653857809). The composed consumer MODULE.bazel now carries rules_dx's protobuf single_version_override and its patch, as it does for rules_py and rules_flutter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
…aterialize test writes rules_julia patches (part of #11443) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
Part of #12277.
Root cause (windows_arm64 pkl lint): the runner hands
lsp_checkverbatim scratch paths (\\?\C:\...).file_uriturned them intofile:////%3F/C%3A/..., pkl-lsp threw intextDocument/didOpen(SettingsManager.handleTextDocumentEvent, shown by run 43659879059), never published diagnostics, and the session timed out.file_urinow drops the verbatim prefix throughdx_path::without_verbatimand spells UNC paths asfile://host/share/....Also in this PR:
lsp_checkdefault session timeout 45s, so it fails before the 60s small-test limit and shows the server stderr.matrix_harnesswrites the full failure to$TEST_UNDECLARED_OUTPUTS_DIR/matrix_failure.txtand prints it with control characters escaped.Evidence:
lsp_check_testpasses;matrix_pkl_lint_{pass,fail,module,syntax_error}still fail. The didOpen URI error is gone; pkl-lsp now throws inSettingsManager$initialize$1.invoke(SettingsManager.kt:53)(reached fromdidOpenviaMessageBus.emit) and publishes no diagnostics.matrix_haskell_lint_pass/fail(perl, haskell: macOS perl gets Pod modules; cabal cc_wrapper finds an exec-relative cc (part of #12277) #12730 fixed the happy template): run 43656844080Local (linux_x86_64):
//core/quality/lsp_check:lsp_check_test,matrix_pkl_lint_pass,matrix_pkl_lint_failpass;tools/dx check //core/quality/lsp_check/...clean. No nested-Bazel or consumer tests run locally.Remaining:
//core/quality/testdata:matrix_pkl_lint_{pass,fail,module,syntax_error}: pkl-lsp throws atSettingsManager.kt:53during the first didOpen. Check which settings/workspace-folder or root URI that line reads on Windows (likelyinitializerootUri/workspaceFolders or theworkspace/configurationreply from lsp_check), and keep the exception header line of pkl-lsp stderr in the lsp_check error (it is currently cut off).preflight_smoke_teststops timing out on windows_arm64.tools/dx check --affectedwith output saved (previous run reported 2 failing tests, names cut off).🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hvuiHK9vSNJZWiqKfX
write_root_patch_overridescopies the root MODULE.bazelsingle_version_overrideofprotobuf(and its//patches/protobuffiles) into the composed consumer, like rules_py/rules_flutter;patches/protobuf:module_srcsjoins//:module_srcs. When #12723 drops the protobuf override, nothing is copied.Tests:
//tools/testing/hermetic:hermetic_unit_testpasses locally (new unit tests for the filter, show_repo parsing, label mapping, the local-attribute parser and mod argv).//tools/testing/hermetic:cpp_rustbuilds locally; it is a nested test and was not run locally.//tools/testing/nested:dx_nested_testand//tools/testing/hermetic:hermetic_unit_testpass locally (linux_x86_64), also on the combined branchfix-11418-julia-package-name.//tools/testing/hermetic:cpp_ruston the combined branch: run 43660885365 green (dx_generate_check ok, Kotlin coverage green, qualified). Run 43658126513 passed refetch_rules_* and coverage but failed dx_generate_check: the cpp_rust consumer java/kotlin test rules lackedsize = "small", now added intools/testing/hermetic/consumers/cpp_rust/apps/. Run 43656923559 timed out (default 600 s test timeout).the_consumer_materializes_from_dx_initwrites therules_juliapatches main'swrite_rules_py_patchescopies.//tools/testing/hermetic:cpp_rustrun 43558347963 failed beforeno_refetchran: thefetchprobe hitUnable to determine host libc!in rules_py's uv host repo (hermetic: consumer fetch fails in rules_py uv host repo: Unable to determine host libc #12482, fixed by rules_py: uv host repo reports glibc 2.28 without running ldd (part of #12482) #12485). Re-run after rules_py: uv host repo reports glibc 2.28 without running ldd (part of #12482) #12485 merges.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hws3L7Tg4oUvpSvuYD