Repository navigation
fix(p0 studio): balanced responsive workbench, physical lightning RUN/STOP, first-click START intent - #276
Conversation
… injection matrix and wider charts
…aration, cancel on STOP/disconnect
…d same-boot first-click START
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
… first-click intent
…portable Windows EXE
2026-10-21 — UI responsiveness + first-click START bench handoff, exact SHAPR #276 HEAD: Operator screenshot 1240px: injection matrix unnecessarily stretches while phasor/waveform panels shrink; 960px reference is better proportioned. New default 1150x790 (from 1240x760), compact toolbar cutoff <1220, setpoint panel preferred 600/690 and max width 750, charts preferred 450/470 (min 300/340), SplitView remains resizable. Green RUN / muted red STOP physical status in ribbon uses user-provided bolt path, with dedicated packaged Qt SVG assets; strictly FIRST START click in same verified board's preparation now latches one intent for <=6.5s while The direct Windows installer EXE extracted from Actions artifact https://github.com/masarray/arstack61850/actions/runs/39566872323/artifacts/12330164944 is 31,036,429 bytes and SHA-256 Physical acceptance pending: Install EXE; flash exact embedded firmware via Studio; test default window 960/1150/1240/1920 widths, keyboard/tab navigation, chart panel visibility, icon green physical RUN vs red STOP, first-click START immediately after board first READY and during profile preparation, 20 START/STOP iterations, 1h SV continuity, PTP PCAP/click-to-LOCK. Record negative cases boot/reconnect, STOP while queued, firmware update, pending timer expiry. No merge to main or release until hardware gates pass. |
Operator bench screenshots and UI/transaction failures
At 1240px width, 4I+4V input matrix grows needlessly long while phasor/waveform are squeezed. Operator prefers compact presentation like second reference screenshot, with lightning bolt icon green RUN and muted-red STOP, not current generic Ready/Running pill. First START click is often consumed by still-pending profile initialization, requiring a second user click.
Exact corrections
PREPARING 4I+4V,RECOVERING PROFILEorDEVICE FOUND, latch one temporary 6.5s operator intent. Dispatch only after realstartReadywith exact unchanged board boot ID, performing fresh visible 4I+4V scenario snapshot and existing firmware CFG/ACK transaction. Cancel on STOP, USB/device unverify, firmware update or timeout; never queue offline, never persist/replay across reconnect; no blind auto START on app launch.CI/Windows build mandatory; hardware bench must confirm actual first click START, corresponding exact GUI/firmware state and continuous SV output, no false RUN. Do NOT merge
mainor claim physical acceptance from green CI.2026-10-23 PR hygiene disposition — SUPERSEDED, NO MERGE. Exact branch HEAD
b628f2a22ad887d878f84774ce2f2bcbb661fc27was checked with GitHub compare and is an ancestor of integration #286 at0e6c860f61a8780d09064369de5d29eb8c1b88c5(behind_by=0). Closed as a historical stacked checkpoint; its commits remain in the integration lineage and its branch is not deleted. This closure does NOT assert hardware acceptance or authorize merging #286. Divergent branches (especially #284's exclusive AUTO_FAILOVER commits), physical test candidate #285, and feature-unique PRs remain open for separate review.