Skip to content

fix(studio): quiet deferred transport readbacks, compact workspace and deliberate setpoint commits - #280

Closed
masarray wants to merge 25 commits into
fix/p0-studio-responsive-start-first-click-20261021from
fix/studio-compact-safe-deferral-editor-20261021
Closed

masarray wants to merge 25 commits into
fix/p0-studio-responsive-start-first-click-20261021from
fix/studio-compact-safe-deferral-editor-20261021

Conversation

@masarray

@masarray masarray commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #276 (NOT main)

Implements the 2026-10-21 engineering handoff without changing firmware wire semantics.

  • C++ single-owner transport: coalesce one SHOW/PROFILE SHOW/PTP SHOW while exclusive CFG/binary transfer owns serial; dispatch only after stage release, with STOP still using the reserved priority lane. PTP STOP stays VERIFYING through deferral, never guesses OFF, retains a bounded absolute deadline and an actionable terminal error.
  • QML 1024x748 compact default, 425px preferred injection table (465px cap), extra width to plots, approximately equal Phasor/Waveform heights, no frequency preset buttons; accessible PTP details icon.
  • QML magnitude/angle local drafts; no 90ms live apply; idempotent commit on Enter/Tab/focus-out, invalid inline; accepted decimal comma/dot without mixed grouping reinterpretation.
  • Update structural gates and native deterministic session harness with positive+negative exclusive/readback/STOP regression.

Required follow-up: exact HEAD Windows MSVC+Qt GUI/harness build, device bench, screenshot inspection (1024/1152), and confirmed setup .exe URL; CI pass is not physical acceptance. Keep PR stacked; do not merge main or publish stable release.


2026-10-23 PR hygiene disposition — SUPERSEDED, NO MERGE. Exact branch HEAD 6d81ad3abb6ebdc2abf0522661202c8d9b1af8c7 was checked with GitHub compare and is an ancestor of integration #286 at 0e6c860f61a8780d09064369de5d29eb8c1b88c5 (behind_by=0). Closed as a historical stacked checkpoint; its commits remain in the integration lineage and its branch is not deleted. This closure does NOT assert hardware acceptance or authorize merging #286. Divergent branches (especially #284's exclusive AUTO_FAILOVER commits), physical test candidate #285, and feature-unique PRs remain open for separate review.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-21T14:41:03.668479Z d0216e8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Engineering completion checkpoint — 2026-10-22

Exact stacked HEAD: 6d81ad3abb6ebdc2abf0522661202c8d9b1af8c7, based on PR #276 HEAD b628f2a22ad887d878f84774ce2f2bcbb661fc27. PR #280 remains OPEN; no main merge or stable release.

Verified source fixes

  • Exclusive canonical BIN/CFG console readbacks coalesced by kind without user-facing internal-busy toast. Safety STOP priority preserved; PTP STOP readback bounded and board-verified, no invented OFF.
  • 1024x748 default, left panel 405–465px (425 preferred), balanced live Phasor/Waveform. Fixed hidden default dock settings via one-time preferences migration. Reset Dock Layout now shows both plots.
  • Discovered second UX defect in Windows screenshots: injection content clipped at 1366px because root's noncompact breakpoint expanded controls even though the left pane stayed ~425px. Left controls now always use compact sizing, redundant summary removed, and PTP/quality widths bounded.
  • Numeric setpoint drafts commit once on Enter/Tab/focus-out, not 90ms typing idle; comma/dot parsing with inline invalid state.

Exact-commit CI: all SUCCESS

Screenshot acceptance: Windows-built Qt renders Phasor and Waveform at 960, 1024, 1152, 1366, 1920 × DPI 100%, 125%, 150%, 175%; geometry now rejects hidden/undersized plots and injection child overflow. Artifact: arstack-studio-windows-layout-evidence (run 39684601249).

Installer artifact: arstack-studio-native-preview-win-x64-280-6d81ad3abb6ebdc2abf0522661202c8d9b1af8c7 (run 39684601343). Extracted standalone ARStack-Studio-Preview-win-x64-setup.exe SHA-256 58d0379acbc0c843d5ed140d32819a9fe282d46982163c0e3cb55e9c8f49c759; matches CI SHA256SUMS. Package PROVENANCE + firmware manifest agree on source SHA and firmware build ID 6d81ad3abb6ebdc2.

Limit: No physical ESP32-P4 bench acceptance in CI. SOURCE/smpSynch qualification, 4kfps capture and ≥1h sustained operation still require actual board + Ethernet evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant