Repository navigation
fix(studio): proportional 41/59 setpoint layout, equal phasor/wave, commit-only numeric editing - #277
Conversation
…cale-safe decimal parsing
…yping; restore invalid input
…ization and single editor commit
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…oke debounce only
…able visual panels
…event Quality row overflow
… without redundant label
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| and "else signalRow.commitMagnitude()" in matrix | ||
| and "else signalRow.commitPhase()" in matrix | ||
| and "onTextEdited:" in matrix | ||
| and "interval: 90" not in matrix |
There was a problem hiding this comment.
Running python3 apps/arstack_studio/tests/check_operator_workspace.py at this commit always fails at this requirement because SignalMatrix.qml still intentionally contains several onTriggered: matrix.controller.editSignal handlers for its context-menu presets (for example, the Zero action). This check is executed by .github/workflows/arstack-studio-qt.yml, so the Studio CI gate cannot pass; narrow the assertion to the removed timer callbacks rather than forbidding all menu-triggered edits.
Useful? React with 👍 / 👎.
| if (normalized.indexOf(",") !== -1 && normalized.indexOf(".") !== -1) | ||
| return NaN | ||
| normalized = normalized.replace(/,/g, ".") | ||
| if (!/^[+-]?(?:\d+(?:\.\d*)?|\.\d+)(?:[eE][+-]?\d+)?$/.test(normalized)) |
There was a problem hiding this comment.
For the frequency editor, the new normalization does not actually make both 0.5 and 0,5 enterable regardless of locale: frequencyField still has a locale-aware DoubleValidator at line 1176, which validates or rejects keystrokes before parseOperatorNumber() receives them. Thus on locales whose decimal separator differs from the typed character, the alternate form can be filtered or interpreted under grouping rules; the field needs a validator that explicitly accepts both syntaxes, or validation must be left to this parser.
Useful? React with 👍 / 👎.
…nstallation acceptance
|
Repository housekeeping (2026-10-23): closing this older alternative Studio layout/UI proposal as an active merge candidate, in favor of one canonical DRAFT integration PR #286. NOT MERGED; closing does not assert semantic parity or acceptance. Original source head |
1 participant
Physical GUI screenshots #276: left 4I+4V still too wide; Phasor too small vs oversized Waveform; operator input updates prematurely while typing.
Root cause
Main.qml splits left panel with a >600px preferred width and permits a much larger channel table; phasor was capped at 265px while Waveform flex grew to ~400px. SignalMatrix.qml has two 90ms per-keystroke timers that call editSignal while the operator is still typing, which can send partial SETs to a live board. Numeric parsing nominally accepts comma when a dot is absent, but ambiguous/malformed input was not explicitly normalized and controlled at a single commit boundary.
Code at this HEAD
commitMagnitude()/commitPhase()on Enter, tab/focus leave, click outside via passive parent TapHandler, and START scenario flush. Editable draft may be invalid while typing; upon final commit reject and restore last valid model value with an actionable toast (never silently clamp/invalid packet).parseOperatorNumberaccepts decimal 0.5 and 0,5 regardless of Windows locale, optionally scientific notation, rejects ambiguous mixed comma+dot and malformed values. Commit rewrites canonical decimal0.500or0.50. Duplicate unchanged values cause no SET. Link A/B/C and actual active live update remain via existing single controllereditSignal()(SSOT).Gates
CI Qt and Windows portable+installer on this SHA; preview only. Physical operator testing of 960/1040/1150/1240/1920 window widths, 50/50 chart sizing, Enter/Tab/mouse-outside commit and comma decimal input, live wire TX count one per commit, invalid paste restoration, concurrent PTP+SV load. No merge main until physical acceptance. Stacked on #276.