Repository navigation
fix(netops): preserve observed CPU/memory evidence in Ansible facts (PLU-43) - #152
Draft
kayodebristol wants to merge 5 commits into
Draft
kayodebristol wants to merge 5 commits into
kayodebristol wants to merge 5 commits into
Conversation
…mplete facts (PLU-43)
This was referenced Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M1 review-only patch (PLU-43)
Corrects the actual parsed field keys for Cisco and Nokia CPU/memory collection in the Ansible facts module. Preserves existing scalar output paths only when measurements are valid. Adds explicit
OBSERVED/UNKNOWN/UNSUPPORTEDsource-evidence coverage and avoids silently substituting zero or falling back to Cisco for unknown vendors.Tests
Adds 14 synthetic pytest cases: actual Cisco/Nokia parser keys, observed zero, malformed/missing/over-range data, invalid memory totals, command exception, unsupported vendors, and partial coverage. No live device I/O.
Limitations
This is not the full PLU-43 fix. The Cisco interface status-table/detailed counter mismatch, role's unsupported gather selectors and flat-vs-nested assertions, Molecule mocks, BGP/OSPF semantics, real vendor command output/transport fixtures and peer review remain unresolved. The PR stays draft; no merge or deployment. Companion documentation/24-case acceptance matrix is draft PR #151, and source health policy must reconcile with stacked #148 → #149 → #150.
No protected branch was written. Do not use this commit as proof of production health or M1 construction readiness.