Repository navigation
fix(netops): fail closed on unobserved Ansible health role facts (PLU-43) - #153
Draft
kayodebristol wants to merge 7 commits into
Draft
kayodebristol wants to merge 7 commits into
kayodebristol wants to merge 7 commits into
Conversation
kayodebristol
changed the base branch from
review/plu-43-health-facts-20261105
to
main
November 6, 2026 11:32
kayodebristol
changed the base branch from
main
to
review/plu-43-health-facts-20261105
November 6, 2026 11:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Stacked review-only proposal on #152 (CPU/memory parser evidence). Replaces invalid
cpu/memory/ospfgather choices and empty selectors with supported factshealth,interfaces,bgp. Reads observed nested CPU/memory values and evidence rather than flat missing values defaulted to zero. UNKNOWN/unsupported/critical measurements fail when strict mode is enabled; OSPF is rejected explicitly. Does not claim interface/BGP inventory as health proof.Compatibility
Default interface/BGP health checks were unsafe and are now disabled until observation coverage is proven; users seeking inventory may opt in with
netops_health_fail_on_critical: false(not health-certified). Strict mode rejects those checks. CPU and memory remain the default strict checks. Existing Molecule mock fixture is incompatible with actual production return shape; do not consider it passing or production verification. Further work must repair Molecule and verify Cisco/Nokia fixtures.Verification
Synthetic Jinja/PyYAML expression/role contract tests are added for gather selectors, observed zero, high CPU/memory, UNKNOWN, unsupported, default policy, OSPF rejection and no-check failure. GitHub CI/Docs must be checked on final PR head before claiming a pass; no device testing has occurred.
Gates
No merge/deployment/live tests without peer review, final SHA CI, corrected Molecule integration and real-device lab fixtures. No M1 physical/economic construction credit. Related: PLU-43, #151, #152.