Repository navigation
fix(netops): align Ansible interface collection with vendor parsers (PLU-43) - #154
Draft
kayodebristol wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Source inspection of
netops/ansible/modules/netops_facts.pyfound Cisco collection executingshow interfaces statusbut passing it toparse_interface_errors_cisco, which expects detailedshow interfacesrecords. This mismatch can silently return empty inventory and conceal unsupported collection under a default Cisco fallback.Proposed correction
show interfaceswith existing detailed error parser.show portinventory parser.Scope and gates
Stacked on draft PR #153; does not alter protected main and should not be merged without #151/#152/#153 review and qualification. Existing Cisco parser may still emit zero counters when only a header (but no counters) is present; the independently stacked #149 parser proof must be reconciled before calling any interface evidence safety-grade. This PR corrects a transport/parser mismatch only. It is not production health certification.
Molecule, representative vendor CLI fixtures, controlled device tests and peer review remain outstanding. No CDCC physical feasibility or construction authorization credit.
Tracked by PLU-43.