Repository navigation
Compat facts: package id in new/build, line/since/shape in inspect - #116
Merged
Merged
Conversation
…spect shows line, since and shape hash Pins core f873d98 (core#159) with the generators that pin it. Refs ComlineProject/core#119, ComlineProject/runtime#15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of the compatibility work (ComlineProject/core#119, ComlineProject/runtime#15), on ComlineProject/core#159.
comline newwritesid = "<32 hex>"on the line aftercongregation.comline buildadds anidto a config.idp that lacks it (one line, nothing else touched) and prints a note. A package that already has an id is left as it is.comline inspectshows the latest build's line, shape hash and each function's since under each of the package's own protocols, and--jsongainsfacts(nullbefore the first build). Read-only, as before.changes.rsrenders the newPackageIdChangedconfig change.5259393, generationac4425c, comline-rust8d0d659and comline-typescript37cd70f.tests/fixtures/generatorsmoves to the same revs.Checks run locally:
cargo test(122 + 13), both clippy runs with-D warnings, and the threefmt --checks.Generated code is byte-identical to
main's for every cli fixture (chat_project,simple_project,validated_project) in Rustcodeandlibmode and in TypeScript. That holds even after this branch'sbuildhas added the id and facts, soschema_ir_hashdoesn't move.Merge after ComlineProject/generation#100, ComlineProject/comline-rust#89 and ComlineProject/comline-typescript#108.