Repository navigation
Pin core's compat facts: the editor accepts config.idp's id - #110
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cascade step for ComlineProject/core#159 (compatibility facts, step 2 of ComlineProject/core#119 / ComlineProject/runtime#15). Pin only.
wasm/Cargo.toml: core5259393, generationac4425c, comline-rust8d0d659, comline-typescript37cd70f, and language-server2c12332(Pin core's compat facts: config.idp accepts id language-server#94). Same revs as Compat facts: package id in new/build, line/since/shape in inspect cli#116. With these, the editor no longer flags theid = "..."key thatcomline newandcomline buildnow write.fixtures/generators/Cargo.toml: generationac4425c.This catches up from core
076cae0with no source changes. Checked locally:cargo test --manifest-path wasm/Cargo.tomlpasses.wasm/builds release forwasm32-unknown-unknown.fixtures/generatorsbuilds release forwasm32-wasip1.Not run locally:
yarn test/yarn build(CI runs them).Merge last, after ComlineProject/language-server#94.