Skip to content

fix: nosql injection vulnerabilities #3 #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petruki merged 1 commit into from
Nov 1, 2026
Merged

fix: nosql injection vulnerabilities #3 #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/aggregator/configuration-resolvers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ export async function resolveFlatDomain(_source, context) {
}

export async function resolveComponents(source) {
const components = await getComponents({ _id: { $in: source.components } });
const componentIds = source.components.map(component => component._id.toString());
const components = await getComponents({ _id: { $in: componentIds } });
return components.length ? components.map(component => component.name) : [];
}
2 changes: 1 addition & 1 deletion src/services/metric.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export async function deleteMetrics(req) {
}

config = await verifyOwnership(req.admin, config, config.domain, ActionTypes.DELETE, RouterTypes.ADMIN);
await Metric.deleteMany({ domain: config.domain, config: config._id.toString() }).exec();
await Metric.deleteMany({ domain: config.domain.toString(), config: config._id.toString() }).exec();
}

async function aggreagateReasons(aggregate, result) {
Expand Down
6 changes: 3 additions & 3 deletions src/services/slack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ async function hasSlackTicket(slack, ticket_content) {
const tickets = await SlackTicket.find({
slack: slack._id.toString(),
domain: slack.domain.toString(),
environment: ticket_content.environment,
group: ticket_content.group,
switcher: ticket_content.switcher,
environment: ticket_content.environment.toString(),
group: ticket_content.group.toString(),
switcher: ticket_content.switcher?.toString(),
status: ticket_content.status.toString(),
});

Expand Down