Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request addresses several type consistency issues across the codebase, ensuring that IDs and other fields are consistently converted to strings before being used in database queries. This helps prevent potential bugs related to type mismatches when querying MongoDB.
Type consistency improvements:
src/aggregator/configuration-resolvers.js: InresolveComponents, component IDs are now explicitly converted to strings before querying withgetComponents, ensuring reliable lookups.src/services/metric.js: IndeleteMetrics, bothdomainandconfigIDs are converted to strings in theMetric.deleteManyquery, preventing issues with mixed types.src/services/slack.js: InhasSlackTicket, all relevant fields fromticket_content(environment,group,switcher, andstatus) are converted to strings before queryingSlackTicket, improving query accuracy and robustness.