Repository navigation
Spec 002 T026: every Modified row printed, a listed difference - #217
Merged
Merged
Conversation
The user decided on 14 Nov 2026 to keep pdf-export's Modified rows: a pathway with two or more modified edits prints a row for each, where today's report prints none. T019's run found 20 of 50 pathways so in release 98. - spec.md's Assumptions list it; research R2's "at most one Modified row" corrected with a dated note; R9's row marked decided. - compare-report lists it itself, narrowly: a Modified row in ours and not in today's, for a pathway where ours has two or more, is marked recorded with its reason; anything else about Modified rows is still a difference. applyRecorded leaves such a difference as it is. - Tests: the listed case, seen failing without the rule; a Modified row missing or extra where ours has one, and today's own row missing beside two of ours, still caught, seen failing with the rule widened. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adamjohnwright
added a commit
that referenced
this pull request
Nov 14, 2026
Keeps both decisions: R9's Modified row as listed (#217) beside the references' note, and T026 before T027. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 002 (analysis report), T026: the first of the two points T019 left open (research R9), decided on 14 Nov 2026.
The decision: print every edit. In release 98, 20 of the 50 pathways compared have two
modifiededits; today's report prints no Modified row for those, pdf-export prints one for each. pdf-export's behaviour is kept, as a declared difference.spec.mdAssumptions: the difference listed, with the decision and its date.research.md: R2's "at most one Modified row" corrected with a dated note; R9's row marked decided.compare-report:listedModifiedRows(src/compare/report.ts) marks it itself, narrowly: a Modified row in ours and absent in today's, for a pathway where ours has two or more Modified rows, is reported withrecordedset to its reason, so it no longer counts as unrecorded. Anything else about Modified rows is still a difference.applyRecordedleaves a difference the comparison already lists as it is (and uses no--expectedrecord on it).tasks.md: T026 added and ticked; T019's "left open" updated. README'scompare-reportline names the listed difference.Tests
compare-reportexits 0. Seen failing with the rule switched off.section edits text. Seen failing with the rule widened to one row.applyRecordedkeeps a listed difference's reason: seen failing without that change.npm run checkpasses locally.🤖 Generated with Claude Code