Repository navigation
Spec 002 T027: a book's and a web page's references in today's form - #218
Merged
Merged
Conversation
The user decided on 14 Nov 2026 that the analysis report prints these two kinds of reference as today's report does. Today's form is read from analysis-report's ApaStyle: a web page's title and "Retrieved from" its address, without authors or year; a book's authors and year, then its chapter's title and the book's parted by a comma, in italics, then its pages; no publisher or ISBN. So what T019 read as a book's publisher after a comma is the book's title (research R9). - Spec 001's reference() is shared through sectionHtml, so the report gets its own form, reportReference, passed in; spec 001's book is unchanged. Whether it changes too is left as a follow-up. - The address and publisher come from spec 001's literature query as it is; no field added. - compare-report's reader leaves out pdf-export's list number on a reference with no year, which a web page in today's form has none of. - Tests, each seen failing without its change: the fixture graph's book and web page in the report's form, spec 001's unchanged; a book and a web page in today's form and the report's agreeing in compare-report, its today's-form helper taught both from ApaStyle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keeps both decisions: R9's Modified row as listed (#217) beside the references' note, and T026 before T027. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 002 (analysis report), T027: the second of the two points T019 left open (research R9), decided on 14 Nov 2026: the analysis report prints a book's and a web page's references the way today's report does.
Today's form, read from its source. I read
ApaStyleinreactome/analysis-report's1.4.0-SNAPSHOTbuild from its compiled classes. Nothing here shows that this build is the one deployed. What it writes:Title. Retrieved from address, with no authors and no year;Authors (year)., thenChapter, Bookin italics, then, pages; it prints no publisher and no ISBN;A correction to R9: T019 noted "a book's publisher after a comma". The text after the comma is actually the book's title, which follows the chapter title. Today's report prints no publisher. Spec 001's form does print the publisher. On R-HSA-1280215 in release 98 (checked against a private copy of the graph), the report now prints
(2002). Cytokines and the immune system, Cytokine Reference.and<title>. Retrieved from <address>for that pathway's two web pages.Changes
reference()throughsectionHtml. So the report gets its own form,reportReference(src/report/layout.ts), which it passes tosectionHtml. Spec 001's book is unchanged;referenceLeadandreferenceTitleare split out ofreference()without changing what it writes. Follow-up, not done: whether spec 001's book should switch to this form is still open.literaturequery as it stands; no field is added.compare-reportreader now drops pdf-export's list number (3.) from a reference that has no year. In today's form a web page has no year, so the number used to make every web page differ.tasks.mdT027 updated.Tests (each seen failing without its change)
test/report/body.test.ts: the fixture graph's book (which has a publisher) and its web page, read byliterature, print in the report's form. Spec 001's form of the same two is asserted unchanged.test/compare/report.test.ts: a book and a web page printed in today's form and in the report's form agree incompare-report. The today's-form helper now writes both kinds asApaStyledoes. This test also fails without the reader's list-number fix.All 715 tests pass locally against a freshly loaded fixture graph; types, lint and format pass as well. Locally the licence check failed because of a symlinked
node_modulesin my worktree; the same lock file passes it (0 offending).This PR and #217 both add a task to
tasks.mdjust before T021. Whichever merges second will need a rebase.🤖 Generated with Claude Code