Repository navigation
ci: ignore the dashboard's session-only operations in spec coverage - #5
Merged
Merged
Conversation
The web dashboard has its own session-JWT endpoints (an API key is rejected)
that appear in the live OpenAPI spec but are not SDK calls:
- dashboard_list_images GET /v1/uploads (list + search; the SDK wraps the keyed GET /v1/images as list_images)
- dashboard_describe_image POST /v1/uploads/{id}/describe (start an AI description for a stored image)
- dashboard_list_tags GET /v1/uploads/tags (AI tag counts for the dashboard's filter bar)
Same treatment as dashboard_upload / dashboard_delete_image: ignore, don't
cover. Without this the spec-coverage check fails on every push and on the
weekly run. Safe to merge before the API change deploys: an ignored operation
that is not live yet is not an error. Supersedes #4, which only listed the
first of the three.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tde8opdomzAwwCkmME3ePL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The pixelvault API has three web-dashboard operations that authenticate with a dashboard session token (an API key is rejected), so they are not SDK calls:
dashboard_list_imagesGET /v1/uploads(list + filename/description search)dashboard_describe_imagePOST /v1/uploads/{id}/describedashboard_list_tagsGET /v1/uploads/tagsdashboard_list_imagesis already in the live spec, sospec-coverageis red onmaintoday:What
Add the three to
IGNORED, with a comment, next todashboard_upload/dashboard_delete_image. The keyed equivalent of the list is already wrapped aslist_images.Verification
python3 -I scripts/check_spec_coverage.py→spec coverage ok: 15 covered, 18 ignored.Note
This supersedes #4, which lists only the first operation and edits the same line. Merge this one and close #4 (or merge #4 and rebase this).
🤖 Generated with Claude Code
https://claude.ai/code/session_01Tde8opdomzAwwCkmME3ePL