Repository navigation
ci: ignore dashboard_list_images in spec coverage - #4
Closed
facundofarias wants to merge 1 commit into
Closed
facundofarias wants to merge 1 commit into
facundofarias wants to merge 1 commit into
Conversation
pixelvault#405 added GET /v1/uploads (operationId dashboard_list_images), the web dashboard's session-authenticated image list/search. Like dashboard_upload and dashboard_delete_image it is a session endpoint, not an SDK call (the SDK already wraps the keyed GET /v1/images as list_images), so ignore it rather than cover it. Without this the spec-coverage check fails on every push. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
facundofarias
added a commit
that referenced
this pull request
Nov 4, 2026
Adds dashboard_list_images, dashboard_describe_image and dashboard_list_tags (the web dashboard's session-JWT endpoints, not SDK calls) to IGNORED in scripts/check_spec_coverage.py. Fixes the red spec-coverage check on main; supersedes #4. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tde8opdomzAwwCkmME3ePL
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pixelvault#405(merged, live) addedGET /v1/uploadswithoperationId: dashboard_list_images— the web dashboard's session-authenticated image list and filename search. The live-spec coverage check now fails on every push and on the weekly run:What
Add
dashboard_list_imagestoIGNORED, next todashboard_uploadanddashboard_delete_image. It authenticates with a dashboard session JWT (an API key is rejected), so it is not an SDK call; the keyed equivalent is already wrapped aslist_images(GET /v1/images).Verification
python3 -I scripts/check_spec_coverage.pyagainst the live spec exits 1 with the line above.spec coverage ok: 15 covered, 16 ignored.🤖 Generated with Claude Code