Repository navigation
fix(studio): proportional injection/plot workspace, verified bolt RUN/STOP, first-click START handoff - #275
Conversation
…ots at desktop and maximized sizes
… red based only on board state
…preparation; bounded cancellable handoff
…, bounded first-click START intent
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a76054526
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| readonly property bool startQueued: Boolean( | ||
| (ribbon.device && ribbon.device.scenarioApplying) || ribbon.startIntentWaiting) |
There was a problem hiding this comment.
Update the stale startQueued contract check
Update the existing assertion in check_operator_workspace.py together with this expression: line 194 still requires the exact old Boolean(ribbon.device && ribbon.device.scenarioApplying) text, so running python3 apps/arstack_studio/tests/check_operator_workspace.py now fails with SV STOP must remain actionable while the acknowledged scenario transaction is pending. Because .github/workflows/arstack-studio-qt.yml runs this script, the Studio CI job fails for every revision containing this commit even though the new contract check added later passes.
AGENTS.md reference: AGENTS.md:L230-L236
Useful? React with 👍 / 👎.
#275 final installer handoff, exact-head verification (2026-10-21)Head Implemented: proportionally bounded injector field panel (505/610px preferred, max 660) while phasor/waveform dock flexes; requested exact bolt SVG glyph RUN green / STOP muted red based on native verified device.running; both icons explicitly included in Qt CMake resources. A single operator START clicked during same-boot PREPARING 4I+4V is retained max 8s, dispatches current scenario once after actual startReady via existing native ACK/readback transaction, cancel on STOP, device-unverified/boot-change or timeout. No fake RUNNING or auto-restart on reconnection. Direct 31MB Windows installer Physical board first-click scenario and GUI dimensions at multiple DPI remain pending user field acceptance; prior PTP/SMV reliability issues are not proven resolved by these UI changes. Do not merge to main or public release. |
Field feedback on preview #273: desktop workspace and first START click
Operator supplied screenshots at 1240px wide / 960px wide. At native desktop width the injector table becomes needlessly long while phasor and waveform are squeezed into a narrow strip. The RUNNING pill is visually weak. On opening the app, clicking START once while native SmartSession is still PREPARING 4I+4V currently discards the click and requires the operator to click again.
Changes
CI and acceptance
Run Qt native session harness, QML smoke at multiple window sizes, Windows Lifecycle and Native Preview exact SHA. Need physical bench proving first click succeeds while initial profile preparation is in progress, no auto-START after firmware update/reconnect, editable profile transactions remain fail-closed. Keep stacked PR OPEN/unmerged to main; no hardware acceptance claim.