Repository navigation
Conversation
…table diagnostics fallback
…ult in main dialog
…rejection and timeout
…reply timeout and bounded stage flow
…back and PTP preflight
…stalled Inno payload
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec6a9d3dc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| text: diagnosticsDialog.visible && workflowBar.session | ||
| ? workflowBar.session.diagnosticsText() : device.logText |
There was a problem hiding this comment.
Keep the diagnostics snapshot reactive
While the dialog remains open, this binding has no dependency on device.logTextChanged, PTP state changes, or the other signals that affect diagnosticsText(); QML cannot observe property reads performed inside the C++ invokable. Consequently, incoming diagnostics never appear, the Clear button leaves the old log visible, and the manual clipboard fallback can show a stale snapshot until the dialog is closed and reopened. Expose the snapshot as a notified property or explicitly bind/recompute it from the relevant change signals.
Useful? React with 👍 / 👎.
Scope
Validation
Review and CI are required before this branch is packaged for operator verification. Hardware START remains to be checked with exact bundled ESP32-P4 firmware; never claim remote board changed from source edits alone.
Stack
PR based on #265, itself stacked on #264/#262; not on historical main. Avoid merging into main alone before upstream stacked changes.