Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2beb4e592c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onToggled: { | ||
| // Link is an editing preference, not a wire | ||
| // setpoint. No 8-channel live replay or | ||
| // pendingApply on a presentation-only switch. | ||
| root.phaseLink = checked | ||
| // Linking phases changes future edit behavior only; | ||
| // never silently rewrite existing setpoints. | ||
| root.markScenarioDirty() | ||
| if (workflowBar.injectionRunning && workflowBar.session | ||
| && workflowBar.session.liveControlReady) { | ||
| // Persist *all eight current table values* on | ||
| // live link changes; the displayed draft | ||
| // must never silently diverge from TX. | ||
| var ok = true | ||
| for (var group = 0; group < 2; ++group) | ||
| for (var row = 0; row < 4; ++row) | ||
| ok = root.sendSignal(group, row) && ok | ||
| if (ok) root.pendingApply = false | ||
| else root.showMessage("Not all live phases were sent. Stop/Start to apply the table.", true) | ||
| } | ||
| root.saveScenarioTimer.restart() |
There was a problem hiding this comment.
This replacement removes the last root.sendSignal(group, row) occurrence, but check_operator_workspace.py:141 still requires that exact string. The mandatory Studio workflow runs this checker for changes under apps/arstack_studio/**, and executing python3 apps/arstack_studio/tests/check_operator_workspace.py now fails with tables and live sent phases must use explicit bounded layout, so every affected non-draft PR is blocked before the Qt build. Update the stale assertion to validate the new no-replay contract.
AGENTS.md reference: AGENTS.md:L230-L236
Useful? React with 👍 / 👎.
1 participant
Stacked independently on #252 to avoid mixing GUI and firmware P0 changes. Removes both channel enable checkbox delegates and their column spacer in SignalMatrix. Replaces the global-free 3-phase link control with a native accessible animated Switch. Link ON/OFF changes future edits and persists local preference only: NO replay of 8 live SETs and NO pendingApply flip. Preserves startup snapshot/transaction and F5/F6 handling. Legacy disabled preset rows are migrated at app restore (before any device connection) to enabled zero magnitude, with explicit operator warning and persisted updated scenario; runtime START rejects unexpected hidden disabled rows. Adds operator workspace structural assertions. Needs exact-HEAD Qt/Windows CI and manual DPI screenshot acceptance. No main merge.