Repository navigation
feat(alexandria): default search to web, alexandria, and skills (1.28.1) - #360
developersdigest wants to merge 17 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 5 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Adds a capped find-tools retry, new shared/provider-skill CLI behavior, and surfaces a merged execution price catalog in list/find-tools output; the retry, output-contract, and pricing decisions need human sign-off.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Adds a capped find-tools retry, new provider-skill list/read commands, and surfaces a hard-coded execution-price catalog into list/find-tools output; the retry policy, price values, and CLI output changes need human sign-off.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 5 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved P0–P2 issue from previous reviews.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Reworks Alexandria CLI: find-tools retry, provider-skill listing, skills create/update changes (--shared removed), and hard-coded prices exposed. The retry policy, price values, and CLI-contract change need human sign-off.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 6 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Expands the Alexandria CLI with skills commands, provider-skill listing, search skill cards, find-tools retry, and hard-coded prices; dismissed findings are fixed, but new retry/price/CLI-contract decisions need human sign-off.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Feature expansion: new skills commands, an authenticated default alexandria-skills search source, find-tools retry/backoff, and a hard-coded price catalog require product/operational sign-off.
View guided diff | Turn on auto-fix | Re-trigger cubic
6b72b73 to
a75a529
Compare
|
@cubic review |
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Shadow auto-approve: would require human review. Adds find-tools 503 retry, provider skill listing/reading, and a merged price catalog; the retry policy and the new default alexandria-skills search source are tradeoffs that need human sign-off.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Shadow auto-approve: would require human review. Adds a 3-second-capped automatic retry for find-tools and adds alexandria-skills to the default keyed search sources; both are operational and default-surface tradeoffs that need human sign-off.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Broad Alexandria CLI feature expansion: new skills commands, default authenticated searches now include alexandria-skills, find-tools gains retry/backoff, and a hard-coded price catalog changes user-facing and operational behavior.
View guided diff | Turn on auto-fix | Re-trigger cubic
Retry a find-tools 503 query_embed_unavailable once, honoring Retry-After up to 3 seconds. Add --shared to create-skill and update-skill, list and read provider-published skills, and record the merged Carbon Arc, Influencers.club, and People Data Labs prices. Bump the version to 1.27.0.
Show merged catalog prices on find-tools and list when --include-costs is set, and price the Influencers.club search and transcript variants. Cap find-skills at 20, fail a provider read that cannot load SKILL.md, and cover shared create plus the file payload. Drop the flaky retry deadline.
skills list --provider returns that provider's published skills and omits execution-only skills. skills read takes --provider, --plugin, and --skill, with --file for the skill file. create and update are unchanged. find-skills and read-skill remain the same commands.
Inherit provider and plugin from a grouped Exchange payload before filtering a provider listing, and treat execution-only markers the same regardless of case or underscores.
Exchange create and update reject a sharing option, so the CLI no longer offers --shared. Update still sends enabled and discoverable. Provider lists send provider and q, follow pages, and match provider.slug and plugin.id, including execution-only skills Exchange returns for a named provider.
A successful create or update prints https://www.firecrawl.dev/app/alexandria/skills/<slug>, using the slug without the team: prefix, and includes that link as url. The Exchange sharePath is not used.
Keep requesting provider skill pages until a short or empty page when Exchange omits total. Match a query before deduplicating, so an earlier non-matching copy cannot hide a later hit. Document --body-file and --request-id on skill writes.
When search returns data.skills, show those cards after web results and tools and include them in --json. A response without the field is unchanged. The skills list query is a natural-language goal: official and provider skills are semantic, and team skills still match every word.
A provider skill card prints skills read --provider, --plugin, and --skill. Official and team cards still use the skill id. Provider list queries stay semantic: the server ranks q, and the CLI no longer requires every query word.
With an API key and no --sources, search sends web, alexandria, and alexandria-skills. An explicit source list is kept, and a search without a key does not add skill cards. A discovery refusal still retries without the sources the CLI added.
A discovery refusal is retried only when every discovery source was added by the CLI. An explicit alexandria-skills request is not retried. The changelog notes that a key still adds alexandria to an explicit source list.
Main already published 1.28.0. Format the search options table so the skill-source default sits with main's scrape flags.
Treat a 2xx Exchange envelope with success false as an error, send the printed request id as X-Request-ID, and keep provider skills that have no id. Skill cards print the id on its own line, and the changelog mentions --body-file and --request-id.
A card with no id omits the ID line. The changelog and README now match that.
A search skill card prints a read command only when the card has an id. The README and changelog say that a card without an id omits the hint.
The API source is skills. With an API key and no --sources, search still sends web, alexandria, and skills.
ede0a12 to
bdc81d5
Compare
|
@cubic review |
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Shadow auto-approve: would not auto-approve because issues were found.
View guided diff | Turn on auto-fix | Re-trigger cubic
API provider, plugin, and skill values are copied into a shell command. Quote any argument that is not a plain token, including the skill id.
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Broad Alexandria CLI feature expansion: default keyed searches now add skills and print skill cards, new skills command set, merged price catalog, and find-tools retry; these change user-visible and operational behavior and need human sign-off.
View guided diff | Turn on auto-fix | Re-trigger cubic
Updates the Alexandria CLI for the latest Exchange changes and bumps the package to 1.28.1. With an API key and no
--sources,searchsendsweb,alexandria, andskills. Main already published 1.28.0, so this release note moved forward. This does not publish to npm or tag a release. Rebased onto current main.Commands and flags
The skills surface is four operations: list, read, create, and update.
skills list|read|create|updateare the same commands asfind-skills,read-skill,create-skill, andupdate-skill.find-toolsretries once when the scrape returns HTTP 503query_embed_unavailable. It waits forRetry-Afterand never longer than 3 seconds, reuses the same request id, and if the second attempt fails printsretryable: truewith a message to run the command again.skills createsendsfrom,name,description,body, andslug.skills updatesendsid,baseVersion,name,description,body,enabled, anddiscoverable. Both accept--body-filein place of--bodyand--request-idto retry the same save.--enabledand--discoverableturn a skill off or hide it. There is no delete, and no Exchange route was added for sharing.skills createorskills updateprintshttps://www.firecrawl.dev/app/alexandria/skills/<slug>, using the slug without theteam:prefix, and includes that link asurlin--json. ExchangesharePath(/skills/s/<publicId>) is not used.skills listtakes a natural-language goal. Official and provider skills are ranked semantically; team skills still match every word.--provider <provider>sendsprovider,q, andpageand follows pages until the catalogue is covered (including when Exchange omitstotal). It matchesprovider.slugandplugin.idand does not re-filter the server's ranking by literal words. A named provider includes the execution-only skills Exchange returns for it. The unfiltered catalogue does not call the provider-skills endpoint.skills readreads a Firecrawl or team skill by id.--provider,--plugin, and--skillread a provider skill;--filereads its file (GET /exchange/provider-skills/:provider/:plugin/:skill/file).searchacceptsskillsin--sources. With an API key and no--sources, it sendsweb,alexandria, andskills. An explicit--sourceslist is used as given (alexandria is still added when a key is set). A search without a key does not addskills. When the response includesdata.skills(id, name, description, sourceofficialorprovider, optional provider slug, similarity), search prints a Skills section after web results and tools. Official and team cards hintfirecrawl skills read <id>. Provider cards hintfirecrawl skills read --provider <provider> --plugin <plugin> --skill <skill>.--jsonincludes the same cards. A response withoutdata.skillsis unchanged.--asyncflag. People Data Labs async enrichment stays execution-only.Provider skills are forwarded
apps/apiin firecrawl/firecrawl does forward them.GETandPATCH /exchange/provider-skills{/*path}proxy to Exchange/v1/provider-skills(FORWARDED_PATH_ROOTS, Labs rate limit, noexchangeRetrieverequirement; firecrawl/firecrawl#5487).POST,PUT, andDELETEare not registered. The CLI only lists and reads, so it usesGET. Search skill cards usePOST /v2/searchwith sourceskills(firecrawl/firecrawl#5560).Prices
src/utils/alexandria-prices.tsrecords merged execution prices:return_filter_values, similar creators 50, audience overlap and full enrich 330, and the remaining enrich, content, and free dictionary lookups).person/enrichandperson/identify60 per successful call;person/search,person/bulk,company/search, andcompany/bulk50 per returned or matched record;company/enrich50 per successful call; preview, IP enrich, and jobs endpoints 1; cleaners and autocomplete 0. Misses are free.listandfind-toolsfill a missing discovery price from that catalog when--include-costsis set.searchalways omits tool prices.Tests
Integration coverage is in
src/__tests__/alexandria-beta.test.ts(retry cap, unknown--sharedrejected,--enabledand--discoverableon update, the app skill link on create and update,--providerquery and paging against the live object shape, paging whentotalis omitted, provider read with--file, defaultskillson search). Search skill cards, the default source list, and the list-query help are insrc/__tests__/commands/search.test.ts. Price and helper checks are insrc/__tests__/utils/alexandria-prices.test.ts.Summary by cubic
Updates the Alexandria CLI for the latest Exchange changes and bumps the package to 1.28.1 without publishing to npm or tagging a release. With an API key and no
--sources,searchnow sendsweb,alexandria, andskills.Skills
githubsearch category andresearch search-github; 2xx Exchange envelopes reporting success false are now treated as errors across skill and tool calls.find-toolsretries once on HTTP 503query_embed_unavailable, honoringRetry-Aftercapped at 3 seconds and reusing the request id; a second failure printsretryable: true. The printed request id is also sent asX-Request-ID.searchsendsweb,alexandria, andskillsunless--sourcesis set; an explicit list is kept as given, and a keyless search adds nothing. A discovery refusal retries only when every discovery source was added by the CLI.skills listtakes a natural-language goal and lists provider-published skills with--provider, including execution-only skills, capping results at 20 by default. It handles flat and grouped payloads, keeps paging when Exchange omitstotal, and keeps provider skills without an id; team skills still match every word.read-skillreads a provider skill with--provider,--plugin, and--skill, or its file with--file, and fails when the file cannot be loaded.create-skillandupdate-skillsendfrom/name/description/body/slugandid/baseVersion/enabled/discoverable; Exchange accepts no sharing option, and--enabled falseor--discoverable falseturn a skill off or hide it. A successful save prints the app skill page, included asurlin--json.searchprints a Skills section after web results and tools whendata.skillsis present and includes it in--json; the skill id line and the read hint print only when the card has an id. Read hints quote provider, plugin, skill, and id values that are not plain tokens. A response without skills is unchanged.Retries and prices
return_filter_values, 20 for a TikTok transcript), and People Data Labs (misses free).listandfind-toolsfill missing discovery prices from the catalog with--include-costs;searchalways omits tool prices. People Data Labs async enrichment stays execution-only and has no flag.Written for commit 7e6bf93. Summary will update on new commits.