Repository navigation
fix(alexandria): point keyless users to sign-in instead of an access error - #362
Draft
JuampiHernandez wants to merge 1 commit into
Draft
JuampiHernandez wants to merge 1 commit into
JuampiHernandez wants to merge 1 commit into
Conversation
Contributor
|
@cubic-dev-ai review this PR |
Contributor
@capy-ai[bot] I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Updates the keyless Alexandria error message to direct users to sign in or set an API key, with tests now asserting the new text. This is a bounded, copy-only fix with no behavior, contract, or operational changes.
View guided diff | Turn on auto-fix | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyless error for Alexandria commands still says "Alexandria requires a Firecrawl API key with access enabled." That wording dates from the beta (#223). Any Firecrawl API key works now, Free plan included (a few tools need a paid plan or an admin to accept the provider's terms), and the server only refuses keyless callers, so the message sends people looking for an access setting that no longer exists.
The new message says what to do instead:
Changes
src/commands/alexandria.ts: new text inrequireAlexandriaKey.src/__tests__/alexandria-beta.test.ts: the keyless Find Tools test now checks the message as well as the exit code.No bundled skill or README repeats the old wording, so nothing else changes.
How I tested it
pnpm type-checkandpnpm format:checkpass.pnpm test: 871 of 872 pass. The one failure (parse.test.ts, "posts to /v2/parse without auth when using the default cloud API with no key") happens on main too when FIRECRAWL_API_KEY is set in the shell, and passes with it unset.firecrawl alexandria find-toolswith no key prints the new message and exits 1.Overlap with #360
#360 edits the same file. This PR changes one string and adds two assertions to an existing test, so it rebases onto #360 trivially, or the other way round.
Summary by cubic
Fixes the keyless error message for Alexandria commands so users are told how to authenticate instead of being sent looking for an access setting that no longer exists.
The message now points to
firecrawl login --browseror settingFIRECRAWL_API_KEY, and the keyless Find Tools test verifies both the exit code and the new message text.Written for commit c5670c7. Summary will update on new commits.