Skip to content

fix: remove single-argument binding of PrepareRefParList to make it silent by default #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clemisch wants to merge 3 commits into
base: nanobind_migration_test
Choose a base branch
from
Open

fix: remove single-argument binding of PrepareRefParList to make it silent by default #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
493b6d8
remove single-argument binding of PrepareRefParList
clemisch Nov 13, 2026
a2f6f0d
add news file
clemisch Nov 13, 2026
c91557f
fix news file
clemisch Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions news/130.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
**Added:**

* <news item>

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* ``LSQ.PrepareRefParList()`` is silent by default again in the nanobind
bindings, as documented. Pass ``verbose=True`` to show the warnings
about duplicate parameter names.

**Security:**

* <news item>
3 changes: 0 additions & 3 deletions src/extensions/nb_lsq.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,6 @@ void wrap_lsq(nb::module_& m)
nb::overload_cast<>(&LSQNumObj::GetCompiledRefinedObj),
nb::rv_policy::reference_internal)
.def("PrintRefResults", &LSQNumObj::PrintRefResults)
.def("PrepareRefParList",
nb::overload_cast<const bool>(&LSQNumObj::PrepareRefParList),
nb::arg("copy_param") = false)
.def("PrepareRefParList",
nb::overload_cast<const bool, const bool>(&LSQNumObj::PrepareRefParList),
nb::arg("copy_param") = false,
Expand Down
Loading