Skip to content

fix: remove single-argument binding of PrepareRefParList to make it silent by default - #130

Open
clemisch wants to merge 3 commits into
diffpy:nanobind_migration_testfrom
clemisch:129_preparerefparlist-silent
Open

clemisch wants to merge 3 commits into
diffpy:nanobind_migration_testfrom
clemisch:129_preparerefparlist-silent

Conversation

@clemisch

@clemisch clemisch commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

fixes #129


from pyobjcryst.crystal import Crystal
from pyobjcryst.lsq import LSQ

c1 = Crystal(4.0, 5.0, 6.0, "P1")
c2 = Crystal(4.0, 5.0, 6.0, "P1")

lsq = LSQ()
lsq.SetRefinedObj(c1, 0, True, False)
lsq.SetRefinedObj(c2, 0, False, False)

# should be silent but isn't 
print("### PrepareRefParList(copy_param=False)")
lsq.PrepareRefParList(copy_param=False)

# is silent
print("### PrepareRefParList(copy_param=False, verbose=False)")
lsq.PrepareRefParList(copy_param=False, verbose=False)

now gives

### PrepareRefParList(copy_param=False)
### PrepareRefParList(copy_param=False, verbose=False)

@clemisch clemisch changed the title Remove single-argument binding of PrepareRefParList to make it silent by default fix: remove single-argument binding of PrepareRefParList to make it silent by default Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant