Repository navigation
fix(datasource): convert CSV datetime columns after parsing - #1471
Merged
XiaJunjie2020 merged 1 commit intoNov 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing a CSV datasource with a column set to the time (datetime) type in the import dialog returns HTTP 500, because pandas' CSV parser does not accept
datetime64[ns]in itsdtypeargument. The exception occurs before the import can process otherwise valid dates.Read explicitly selected CSV datetime columns as strings, then convert them to the existing datetime dtype after parsing. This preserves date and time values and missing cells, rejects invalid dates, and leaves Excel reading and integer rounding unchanged.
Testing and validation
Five offline regression tests exercise the actual import function with dates, empty cells, time components, invalid dates, explicitly selected strings, an empty CSV, and integer rounding alongside datetime conversion. Before the fix, three tests error with the unsupported datetime dtype; after the fix, all five pass with Python 3.11.18 and pandas 2.3.3:
HTTP, database persistence, browser interactions and deployment were not exercised.