Repository navigation
fix(datasource): remove duplicate CSV check left by merge - #1473
Merged
Merged
Conversation
The merge of main into dataease#1457 kept both the old and the new CSV condition in read_import_dataframe, leaving an `if` with no body. apps/datasource/utils/excel.py fails to import with IndentationError.
Kapozux
force-pushed
the
fix/csv-import-indentation
branch
from
November 17, 2026 11:49
376332e to
68a7977
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge of
maininto #1457 kept both the old and the new CSV condition inread_import_dataframe, somain(4f045ba) now has anifwith no body:backend/apps/datasource/utils/excel.pyfails to import withIndentationError: expected an indented block after 'if' statement on line 58, and the datasource API imports it.This removes the leftover line. The case-insensitive check from #1457 and the datetime handling from #1471 are both kept.
Verification
tests/test_datasource_csv_extension.pyandtests/test_csv_datetime_import.py: collection fails with the IndentationError onmain; 12 pass with this change.py_compilepasses for every file underbackend/appsandbackend/common.