Skip to content

fix(datasource): remove duplicate CSV check left by merge - #1473

Merged
XiaJunjie2020 merged 1 commit into
dataease:mainfrom
Kapozux:fix/csv-import-indentation
Nov 17, 2026
Merged

XiaJunjie2020 merged 1 commit into
dataease:mainfrom
Kapozux:fix/csv-import-indentation

Conversation

@Kapozux

@Kapozux Kapozux commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The merge of main into #1457 kept both the old and the new CSV condition in read_import_dataframe, so main (4f045ba) now has an if with no body:

    if is_csv_file(save_path):
    if save_path.endswith('.csv'):

backend/apps/datasource/utils/excel.py fails to import with IndentationError: expected an indented block after 'if' statement on line 58, and the datasource API imports it.

This removes the leftover line. The case-insensitive check from #1457 and the datetime handling from #1471 are both kept.

Verification

  • tests/test_datasource_csv_extension.py and tests/test_csv_datetime_import.py: collection fails with the IndentationError on main; 12 pass with this change.
  • py_compile passes for every file under backend/apps and backend/common.

The merge of main into dataease#1457 kept both the old and the new CSV
condition in read_import_dataframe, leaving an `if` with no body.
apps/datasource/utils/excel.py fails to import with IndentationError.
@Kapozux
Kapozux force-pushed the fix/csv-import-indentation branch from 376332e to 68a7977 Compare November 17, 2026 11:49
@XiaJunjie2020
XiaJunjie2020 merged commit 14704b6 into dataease:main Nov 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants