Repository navigation
Conversation
denik
added this pull request to stack #7089
October 16, 2026 09:24
denik
removed this pull request from stack #7089
October 16, 2026 09:31
denik
force-pushed
the
denik/dms-prefetch-node
branch
from
October 16, 2026 09:39
79e17eb to
bbbc19d
Compare
denik
added this pull request to stack #7091
October 16, 2026 09:39
Collaborator
Integration test reportCommit: 81fea9b
Top 6 slowest tests (at least 2 minutes):
|
…e reads With deployment history configured, plan/deploy/destroy read resources.json and only then get-status resources.deployment.json to find the deployment id. readStates now runs that lookup concurrently with the state reads and passes the result on StateDesc, saving one sequential round trip. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/dms-prefetch-node
branch
from
October 16, 2026 10:57
bbbc19d to
81fea9b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
With deployment history configured,
readStatesnow runs theresources.deployment.jsonget-status concurrently with theresources.json/terraform.tfstatereads and hands the id tofetchDeploymentFromStatePathonStateDesc. The lookup moved todms.LookupDeploymentID.Why
plan/deploy/destroy always pull remote state, so with deployment history on they did export → get-status → GetDeployment one after another. Now it is max(export, get-status) → GetDeployment: one round trip less. Follows #7075, which removed the get-status before each state read.
Whether the state records history is only known after reading it, so the lookup is gated on the config; a state that disagrees is rejected or looked up again as before.
Tests
Same requests are made, just concurrently, so no golden changes; DMS acceptance tests pass, 15 repeated runs without ordering flakes.
This pull request and its description were written by Isaac.