Repository navigation
Conversation
denik
added this pull request to stack #7089
October 16, 2026 09:24
denik
force-pushed
the
denik/dms-sticky
branch
2 times, most recently
from
October 16, 2026 09:26
7db57bb to
3620b2d
Compare
denik
removed this pull request from stack #7089
October 16, 2026 09:31
denik
force-pushed
the
denik/dms-sticky
branch
from
October 16, 2026 09:39
3620b2d to
4edf639
Compare
denik
changed the base branch from
denik/state-dir-not-a-file
to
denik/dms-prefetch-node
October 16, 2026 09:39
denik
added this pull request to stack #7091
October 16, 2026 09:39
Collaborator
Integration test reportCommit: fd82991
Top 6 slowest tests (at least 2 minutes):
|
A deployment that records history now keeps recording when experimental.deployment_history is left out; only an explicit false conflicts with the state. The state pull also starts the deployment lookup when the local state records history, not only when the config enables it. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/dms-sticky
branch
from
October 16, 2026 10:57
4edf639 to
fd82991
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A deployment that records history keeps recording when
experimental.deployment_historyis not set; only an explicitfalseconflicts with the state. The state pull also starts the deployment lookup from #7086 when the local state records history, not only when the config enables it.Why
Recording already followed the state everywhere except the setting check, which rejected a deploy once the line was removed from
databricks.yml. The service still holds the deployment, so leaving the setting out should not turn it off.Tests
New
acceptance/bundle/dms/sticky: deploy with recording, drop the setting and deploy (records version 2), wipe.databricksand plan, then an explicitfalseis refused. Fails without the fix.This pull request and its description were written by Isaac.