Repository navigation
Conversation
Releases were cut by hand with `gh release create` until 0.11.1, and the release checklist never named that step, so 0.12.0 to 0.17.3 went to PyPI with no release page (and benchmark.yml skipped its notes for each). A new job creates the release once PyPI has the version, with the tag's section of docs/changelog.md as its notes; check-version refuses a tag with no section before anything is published. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub releases stop at 0.11.1, though 0.12.0 to 0.17.3 are tagged and on PyPI. Releases were cut by hand with
gh release create, and the checklist in AGENTS.md and docs/developers.md never named that step. So from 0.12.0 on, tags were pushed with no release page.benchmark.ymlthen found no release to append its summary to, and logged "skipping" each time.publish.yml: a newgithub-releasejob runs afterpublish-pypiand creates the release, using the tag's## X.Y.Zsection ofdocs/changelog.mdas the notes. It leaves alone a release that was already cut by hand.check-versionnow also refuses a tag that has no changelog section, before anything is published.benchmark.yml: only the comment changes. The release now normally exists by the time the append step runs.The 11 missing releases (0.12.0 to 0.17.3) are backfilled separately. Each takes its changelog section plus that tag's
benchmark-X.Y.Zartifact summary, in the same blockbenchmark.ymlwrites.Checked:
actionlintandyamllintare clean. I ran the awk extraction against the changelog for 0.12.0 and 0.17.3; a missing tag gives empty notes, so the job fails.tests/test_docs_are_accurate.pypasses. The real end-to-end check is the next tag.🤖 Generated with Claude Code