Repository navigation
Conversation
Each API call assembled its own curl command line. Route them all through teamwork::request so the options live in one place. The helper also passes -sS. curl prints a progress meter when its output is captured, which filled the logs with timings that change on every run; -S still shows errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI only ran the action in test mode, where every Teamwork request is skipped, so nothing checked what the action actually sends. tests/run.sh builds the image, starts a mock Teamwork API (tests/mock-teamwork.py) on a private Docker network, and runs each case in tests/cases the way the GitHub runner would: args built from action.yml, inputs as INPUT_* env vars. It compares the exit code, stderr and every request the mock received with the case's expected file. The expected files record the current behaviour, bugs included, so the fixes that follow show up as changes to them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 20, 2026
seanogdev
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 1. #75 tests → 2. #76 bug fixes → 3. #77 link matching → 4. #78 secrets → 5. #79 test mode removal
Summary
CI only ran the action in test mode, which skips every Teamwork request, so nothing checked what the action actually sends.
tests/run.shnow runs the real image against a mock Teamwork API for 22 cases, comparing the exit code, errors and every request received with a recordedexpectedfile. Those files capture today's behaviour, bugs included, so the fixes in the next PRs show up as changes to them. CI runs the suite in the existing "Ensure this project runs" job, and curl now runs with-sSbecause its progress meter made the output differ between runs.Evidence
Before: CI's only check is test mode, which logs
Test - Simulate request...and sends nothing.After:
./tests/run.sh→All 22 case(s) passedin about 15 seconds, identical across runs. The snapshots already show the bugs the next PRs fix, e.g.tests/cases/task-not-found/expected, where the run carries on after the lookup fails and still passes:🤖 Generated with Claude Code