Skip to content

Remove the test mode - #79

Open
marcizhu wants to merge 1 commit into
keep-secrets-out-of-argsfrom
remove-test-mode
Open

marcizhu wants to merge 1 commit into
keep-secrets-out-of-argsfrom
remove-test-mode

Conversation

@marcizhu

Copy link
Copy Markdown
Member

Stack: 1. #75 tests → 2. #76 bug fixes → 3. #77 link matching → 4. #78 secrets → 5. #79 test mode removal

Summary

With #75's tests running the real code, test mode only kept CI from exercising it. This removes it from the action (the ENV=test checks that skipped every request), along with the CI step that relied on it, the old event fixtures and act instructions, and the PR template's dummy task link. CI now runs on pushes to master and on PRs, and the job keeps its name, so a required status check on "Ensure this project runs" keeps working.

Evidence

  • Before: ./tests/run.sh → All 22 case(s) passed
    After: All 22 case(s) passed with no expected file changed, so the real code paths never depended on test mode. No test-mode code is left (grep -rn 'set_environment\|"$ENV"\|Simulate' finds nothing).

🤖 Generated with Claude Code

With the tests running the real code against a mock Teamwork API, the
"skip the request in test mode" branches only kept CI from exercising
the code. Remove them, along with the uses: ./ CI step that relied on
them, the old event fixtures and act instructions, and the dummy task
link in the PR template.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@marcizhu
marcizhu requested a review from a team as a code owner October 20, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants