Repository navigation
Say that an environment opt-out skips the server-wide file - #35
Merged
dmccoystephenson merged 1 commit intoOct 30, 2026
Merged
Conversation
The serverWideConfig Javadoc said build() always makes sure plugins/trace/config.yml exists, but the constructor never reads or creates it once TRACE_USAGE_REPORTING or DO_NOT_TRACK has opted out. readServerWideConfig's Javadoc also left out the server-id: line it reads. The README's "Never throws" row said every drop is logged, which contradicts the "Bounded" row next to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against the diff and CI on head f7b4307):
Do-not-auto-merge path check: none matched. The changed paths are Observation, not blocking: src/main/java/software/stephenson/trace/TraceClient.java:1127, where "read once, here" means in Summary: an accurate, docs-only correction, and ready to merge. This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/docs-env-optout-skips-server-wide-file
branch
October 30, 2026 07:28
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage A documentation accuracy sweep. Each claim was checked against
TraceClient.java,pom.xmlandbuild.yml. Three cases of drift were found and are fixed here. All the changes are documentation; no code changed.Summary
Builder.serverWideConfigJavadoc: it saidbuild()"makes sureplugins/trace/config.ymlexists". The constructor never reads or creates the file onceTRACE_USAGE_REPORTING/DO_NOT_TRACKhas opted out (builder.pluginsDirectory == null || environmentDisables() ? ServerWideConfig.NONE : ...). This is already pinned byinstallId_aDisabledClientNeitherGeneratesNorWritesOne("an environment opt-out touches nothing on disk"). The Javadoc now says so. "Both are read once" also became "All three", because the paragraph lists the switch, thetags:block andserver-id:.readServerWideConfigJavadoc: it named theenabled:line and thetags:block but not theserver-id:line, whichparseServerWideConfigalso reads. It also did not say that the method is skipped under an environment opt-out.reportpromises", "Never throws" row: "Drops are logged atFINE" contradicted the "Bounded" row next to it, which says queue-full drops get no log line. It now reads "Such a failure is logged", which matches the class Javadoc ("Failures are logged at FINE").The same inaccuracy appears in the README "Opting out" table (server-wide row). It is not fixed here, because that section is user-facing disclosure wording that needs maintainer approval. It is filed as #34.
No tracking issue for the fixes in this PR: the drift was found during the sweep.
Checked and found accurate
The version agrees in all four places (0.7.0). The
REASON_*/ENV_*strings and the precedence match the class Javadoc and README.QUEUE_CAPACITY,MAX_COALESCED_EVENTS,COALESCE_WINDOW_MSand the 5 sclose()bound match. So do the wire format (endpoint,Authorization: Bearer,201, value omission), theserver-id:/ install-ID rules and the Building section against thebuild.ymlmatrix (8, 17, 21).Deferred issues
Test plan
mvn -B verifyrun locally on Java 21: 97 tests, 0 failures.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson