Repository navigation
Say in the Opting out table that an environment opt-out skips the file - #36
Merged
Merged
Conversation
The server-wide row said build() creates plugins/trace/config.yml if it is missing. The constructor skips readServerWideConfig entirely once TRACE_USAGE_REPORTING or DO_NOT_TRACK has opted out, so nothing is read or created on disk in that case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (posted as a plain comment; not an independent review):
Judgment call: Merge gate: the diff touches the README "Opting out" section, which is on the do-not-auto-merge list (user-facing disclosure wording). The PR is left open for maintainer approval. This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build()createsplugins/trace/config.ymlif it is missing. That is not true once an environment variable has opted out: theTraceClient(Builder)constructor usesServerWideConfig.NONEwhenenvironmentDisables()is true, andreadServerWideConfig(the only place that creates the file) is never called. The row now says "When the environment has already opted out, the file is neither read nor created."installId_aDisabledClientNeitherGeneratesNorWritesOne. No code changed; theBuilder.serverWideConfigandreadServerWideConfigJavadoc were already corrected in Say that an environment opt-out skips the server-wide file #35.Closes #34
Merge gate
This PR edits the README "Opting out" section, which is user-facing disclosure wording on the do-not-auto-merge list. It is left open for maintainer approval rather than merged automatically.
Deferred issues
Test plan
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson