Repository navigation
Conversation
Every browserslist release that fixes CVE-2026-73088/73089 (>= 4.28.7) depends on node-releases >= 2.0.51, and node-releases has declared engines node >= 18 since 2.0.45, so yarn refuses to install the patched tree on Node 16. Raise engines to >= 18 and run every CI job on Node 18. Breaking for consumers still building on Node 16. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 28, 2026
Open
`pull_request.branches: '*'` doesn't match branch names containing `/`, so PRs stacked on gaurav/chore/... branches never triggered CI. Use '**'. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every browserslist release that fixes CVE-2026-73088 and CVE-2026-73089 (>= 4.28.7) depends on
node-releases>= 2.0.51.node-releaseshas declaredenginesnode >= 18 since 2.0.45, so yarn refuses to install the patched tree on Node 16. This raises the minimum to Node 18 so the later parts of this stack can install.package.json:engines.nodegoes from>= 16to>= 18..github/workflows/ci.yml: every CI job runs on Node 18 instead of 16..github/workflows/ci.yml: thepull_requesttrigger now usesbranches: '**'instead of'*'.'*'does not match branch names containing a slash, so PRs stacked ongaurav/chore/...branches never ran CI. Without this, Parts 2-9 would have no checks until the PR below them merged.No dependency changes.
Breaking for consumers still building on Node 16.
Stack
Part of the SCF-2415 audit work, split from
gaurav/chore/SCF-2415-audit-critical-highfor easier review. This is part 1 of 9 and targetsscf_master.Review notes
Review the CI matrix change and the
enginesbump, and confirm that dropping Node 16 is acceptable.Testing
yarn install --frozen-lockfilepasses on this branch. The full suite (yarn lint,ember test) was run on the top of the stack (Part 9): 0 lint errors, 526 passed, 10 skipped, 0 failed.🤖 Generated with Claude Code