Skip to content

[SCF-2415] [Part 9] Refresh remaining vulnerable dependencies - #14

Open
Gaurav0 wants to merge 9 commits into
gaurav/chore/SCF-2415-part-8-refresh-server-depsfrom
gaurav/chore/SCF-2415-part-9-refresh-remaining-deps
Open

Gaurav0 wants to merge 9 commits into
gaurav/chore/SCF-2415-part-8-refresh-server-depsfrom
gaurav/chore/SCF-2415-part-9-refresh-remaining-deps

Conversation

@Gaurav0

@Gaurav0 Gaurav0 commented Oct 28, 2026 •

Copy link
Copy Markdown

Summary

Final batch of lockfile-only refreshes for the remaining audit findings, plus one resolution for mocha's own copy of js-yaml.

  • terser-webpack-plugin 5.6.1
  • shell-quote 1.12.0
  • form-data 4.0.6
  • @xmldom/xmldom 0.8.15
  • flatted 3.4.4
  • js-yaml 3.15.2, and a resolution forcing mocha/js-yaml to 4.3.2
  • source-map-js 1.2.2
  • underscore 1.13.8

With this part applied, the tree is identical to the original gaurav/chore/SCF-2415-audit-critical-high branch: the same yarn.lock, and the same package.json apart from the order of the resolutions keys.

Stack

Part of the SCF-2415 audit work, split from gaurav/chore/SCF-2415-audit-critical-high for easier review. This is part 9 of 9. Stacked on Part 8: its base is gaurav/chore/SCF-2415-part-8-refresh-server-deps, so the diff only shows this part. Merge in order.

Part PR Title
1 #6 Drop Node 16, require Node 18
2 #7 Remove release-it and release-it-lerna-changelog
3 #8 Move API docs tooling into docs/
4 #9 Dedupe Ember tooling (ember-auto-import 2, ember-source-channel-url 3)
5 #10 Upgrade Babel to 7.29 and force browserslist 4.29.5
6 #11 Force patched tmp, brace-expansion, minimatch, picomatch and braces
7 #12 Force patched fast-uri, nanoid, markdown-it, lodash.template and ansi-html
8 #13 Refresh dev-server and networking dependencies
9 #14 Refresh remaining vulnerable dependencies

Review notes

Lockfile-only apart from the js-yaml resolution. Skim each commit.

Testing

yarn install --frozen-lockfile passes on this branch. The full suite (yarn lint, ember test) was run on the top of the stack (Part 9): 0 lint errors, 526 passed, 10 skipped, 0 failed.

🤖 Generated with Claude Code

Gaurav0 and others added 8 commits October 28, 2026 19:51
webpack 5's terser-webpack-plugin 5.3.14 depended on
serialize-javascript 6.0.2 (high; the fix, 7.x, needs Node >= 20).
5.6.1, still inside webpack's ^5.3.11 range, no longer depends on
serialize-javascript at all. Lockfile refresh only.

The production build bundles the same modules and identifiers; only
webpack's numeric module ids in the two ember-auto-import chunks (and
so their content hashes and the references in index.html) change.

Audit: high 50 -> 49.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shell-quote 1.8.3 (critical, high) -> 1.12.0, within npm-run-all's
^1.6.1 range. npm-run-all drives `yarn lint`, which still runs all its
tasks. Lockfile refresh only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
form-data 4.0.3 (critical, high) -> 4.0.6, within jsdom's ^4.0.0 range.
Lockfile refresh only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@xmldom/xmldom 0.8.10 (13 high findings) -> 0.8.15, within testem's
^0.8.0 range. Lockfile refresh only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
flatted 3.3.3 (high) -> 3.4.4, within flat-cache's ^3.2.9 range
(eslint's cache, exercised by `yarn lint`). Lockfile refresh only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
js-yaml 3.14.1 (ember-cli, testem, tap-parser) and 4.0.0 (mocha) both
have high advisories.
- The ^3 ranges refresh to 3.15.2 (lockfile only).
- mocha 8 pins js-yaml 4.0.0 exactly, so a resolution scoped to mocha
  moves it to 4.3.2 (same major). mocha uses it to read YAML config;
  loading a .mocharc.yml through it still runs all node tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
source-map-js 1.2.1 (high) -> 1.2.2, within css-tree's ^1.0.1 range
(eslint-plugin-ember). It merges with the 1.2.2 copy already in the
tree. Lockfile refresh only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
underscore 1.13.7 (high) -> 1.13.8, within backbone's >=1.8.3 range.
Lockfile refresh only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Gaurav0
Gaurav0 force-pushed the gaurav/chore/SCF-2415-part-8-refresh-server-deps branch from 6a549af to 617be53 Compare October 29, 2026 00:00
@Gaurav0
Gaurav0 force-pushed the gaurav/chore/SCF-2415-part-9-refresh-remaining-deps branch from 2393211 to fa369d5 Compare October 29, 2026 00:01
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant