Repository navigation
feat(admin): superadmins remove an organisation without users - #326
Closed
iheitlager wants to merge 2 commits into
Closed
iheitlager wants to merge 2 commits into
iheitlager wants to merge 2 commits into
Conversation
DELETE /v1/admin/organisations/{id}, superadmin only, a "remove
organisation" button in the web admin tab, and frank participant remove.
Refused with 409 while the organisation has users, disabled ones too,
and when FRANK_SSO_ORGANISATION or FRANK_SSO_ADMIN_ORGANISATION names
it, since serve would not start without it. Audited as
participant_removed; its sightings keep its id as their reporter.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The three admin-group scenarios shared one Tests line after the last, so check-assurance counted two as untested (14/16). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /v1/admin/organisations/{id}, a "remove organisation" button in the web admin tab, andfrank participant remove NAME.FRANK_SSO_ORGANISATIONorFRANK_SSO_ADMIN_ORGANISATIONnames it, sinceservewould not start without it.participant_removed. The organisation's sightings keep its id as their reporter.Changes
Added
store/participants.rs::remove_organisation,admin.rs::remove_organisation,cli.rs::participant_remove.Changed
docs/openapi.yamland the README route table: the newDELETE.tests/mcdc/obligations.json: regenerated for the new decisions (make mcdc-obligations).Tests:line per scenario. The three admin-group scenarios shared one line, socheck-assurancecounted two as untested (14/16). This commit is separate in the branch history.Changelog
frank participant remove; it is audited, and an organisation an SSO setting names is refused.Review Findings
No prior
/reviewrun in this session.Testing
make testpasses (all workspace test binaries, including the new API, SSO, CLI and store tests)make lintpasses (fmt, clippy native and wasm32, qualified-subset gate)make check-assurance: tested 100% (min 95%), 0 dead linksmake test-mcdc: 48/48 decisions of two or more conditions coveredcontainer imagejob runs the browser suite.Related Issues
Closes #324
🤖 Generated with Claude Code