Repository navigation
fix(cli): participant remove keeps the SSO organisations - #327
Merged
Merged
Conversation
The three admin-group scenarios shared one Tests line after the last, so check-assurance counted two as untested (14/16). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The API refused to remove an organisation FRANK_SSO_ORGANISATION or FRANK_SSO_ADMIN_ORGANISATION names, the command line did not: on the host an empty landing organisation could go, and serve would then not start. participant remove reads the same settings (or --sso-organisation and --sso-admin-organisation) and refuses, by name or id. Adds the CLI test, and spec 030 lists the remove button among the superadmin-only controls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frank participant removenow keeps the organisations the SSO settings name, asDELETE /v1/admin/organisations/{id}already did (feat(admin): superadmins remove an organisation without users, from the web UI #325). On the host an empty SSO landing organisation could be removed, andservewould then refuse to start.Changes
Fixed
crates/frank/src/cli.rs:participant removereadsFRANK_SSO_ORGANISATIONandFRANK_SSO_ADMIN_ORGANISATION(or--sso-organisation,--sso-admin-organisation) and refuses an organisation either names, by name or id, naming the setting in the error.Tests:line per scenario. The three admin-group scenarios shared one line, socheck-assurancecounted two as untested (14/16).Changed
participant removeline.tests/mcdc/obligations.json: regenerated (make mcdc-obligations).Added
crates/frank/tests/cli.rs::participant_remove_needs_no_users_and_no_sso_setting.Changelog
frank participant removerefuses an organisationFRANK_SSO_ORGANISATIONorFRANK_SSO_ADMIN_ORGANISATIONnames, as the API does, soservekeeps starting.Testing
make test: 379 passed, 0 failedmake lintcleanmake check-assurance: tested 100%, 0 dead links (spec 012 back to 16/16)make test-mcdc: 48/48 coveredpodman exec frank frank participant remove lab271is refused whileFRANK_SSO_ORGANISATION=lab271Related Issues
Follow-up to #324, which #325 closed. Supersedes the closed duplicate #326.
🤖 Generated with Claude Code