Skip to content

Require binary PR review verdicts - #507

Open
ChristianPavilonis wants to merge 1 commit into
mainfrom
edgezero-binary-review-verdicts
Open

ChristianPavilonis wants to merge 1 commit into
mainfrom
edgezero-binary-review-verdicts

Conversation

@ChristianPavilonis

@ChristianPavilonis ChristianPavilonis commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Make review verdicts binary so reviews are recorded as approval or requested changes rather than easily missed comments.
  • Approve reviews with only optional feedback while keeping blocking findings as REQUEST_CHANGES.
  • Preserve inline feedback and stop self-reviews before submission or draft deletion. A different GitHub identity must submit the prepared review.

Changes

File Change
.claude/agents/pr-reviewer.md Update verdict selection, restrict submission events, and preserve the intended verdict when self-review prevents submission.

Closes

Closes #508

The blocking event is corrected from CHANGES_REQUESTED to the API event name REQUEST_CHANGES. One existing table-spacing mismatch is normalized for the locked formatter.

Test plan

  • Prettier 3.9.10, matching the docs lockfile, with docs/.prettierrc on the changed file.
  • git diff --check.
  • Static assertions for binary verdicts, optional feedback, the self-review stop instruction, and removal of the invalid event name and comment submission paths.
  • Inspect the complete diff and confirm the self-review check precedes pending-review deletion.
  • Rust suites and docs build not run. No application code changed.
  • A live agent review was not submitted during verification.

Checklist

  • Changes are scoped to one agent instruction file.
  • Existing finding classifications and user approval requirements are preserved.
  • No secrets or credentials committed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align PR reviewer with the team's binary verdict policy

1 participant