Skip to content

Align PR reviewer with the team's binary verdict policy #508

Description

@ChristianPavilonis

Description

The team already has an unwritten policy that PR reviews should either approve or request changes. Comment-only reviews are easy to miss and lose track of.

The Claude PR reviewer agent currently conflicts with that policy. It selects COMMENT whenever a review contains non-blocking findings and reserves APPROVE for reviews with no findings or praise alone. This repeatedly forces the reviewer to argue with the agent to submit an approval with a few optional nitpicks.

Write the existing policy into the agent instructions so optional feedback can accompany approval without turning the review into a comment-only submission.

Done when

  • Reviews containing blocking findings submit REQUEST_CHANGES.
  • Reviews with only non-blocking feedback, praise, or no findings submit APPROVE.
  • Optional nitpicks and suggestions remain in inline comments or the review body and are explicitly marked optional.
  • Verdict selection, submission instructions, and examples consistently use only the two verdicts.
  • Self-reviews stop before submission or pending-review deletion, preserve the prepared review and intended verdict, and explain that a different GitHub identity must submit it. They do not fall back to COMMENT.
  • Existing user approval requirements and finding classifications remain intact.

Affected area

CI / Tooling: .claude/agents/pr-reviewer.md.

Implementation

Companion PR: #507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions