Repository navigation
ffi: name jsonrpc@1's decode allocation as a known exception - #61
Merged
Merged
Conversation
…#58) The rules said nothing allocates after comline_connection_new, with no exception, but feeding a jsonrpc@1 frame can: serde_json allocates for a refused frame, an escaped member name, and brackets three deep. The crate doc, comline_connection_new, comline_connection_feed (and so comline.h) and the README now say so until runtime#58 is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C ABI says nothing allocates after
comline_connection_new, with no exception. That's untrue onjsonrpc@1: feeding a frame can allocate inside serde_json. It does for any refused frame, an escaped member name, and brackets nested three deep (#58, deferred). The fuzz and differential driver already exempts exactly those cases (#57).This states the exception where the rule is stated, until #58 is fixed:
comline_connection_new;comline_connection_feed, and socomline.h(regenerated with cbindgen 0.29.2);runtime/ffi/README.md.Docs only, no code change.