Skip to content

Allow more time for cross-origin message delivery tests #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianRappl merged 3 commits into from
Nov 6, 2026
Merged

Allow more time for cross-origin message delivery tests #155

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e0746f
Initial plan
Copilot Nov 6, 2026
c0e6002
Lengthen cross-origin async test wait
Copilot Nov 6, 2026
170f94f
Serialize message tasks through engine runner
Copilot Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions src/AngleSharp.Js/Dom/MessageChannel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,13 +557,27 @@ public static void Enqueue(IDocument document, Action action)

if (loop != null)
{
loop.Enqueue(action, TaskPriority.Normal);
loop.Enqueue(_ => Execute(document, action), TaskPriority.Normal);
return;
}

Queues.GetValue(document, static _ => new TaskQueue()).Enqueue(document, action);
}

private static void Execute(IDocument document, Action action)
{
var scripting = document.Context?.GetService<JsScriptingService>();

if (scripting != null)
{
scripting.GetOrCreateInstance(document).RunTask(action);
}
else
{
action();
}
}

private sealed class TaskQueue
{
private readonly Queue<Action> _actions = new Queue<Action>();
Expand Down Expand Up @@ -620,16 +634,7 @@ private void Run(IDocument document)

try
{
var scripting = document.Context?.GetService<JsScriptingService>();

if (scripting != null)
{
scripting.GetOrCreateInstance(document).RunTask(action);
}
else
{
action();
}
Execute(document, action);
}
catch (Exception error)
{
Expand Down
Loading