Skip to content

Allow more time for cross-origin message delivery tests - #155

Merged
FlorianRappl merged 3 commits into
develfrom
copilot/fix-windows-job-failure
Nov 6, 2026
Merged

FlorianRappl merged 3 commits into
develfrom
copilot/fix-windows-job-failure

Conversation

Copilot AI commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Windows CI failed when the net462 cross-origin postMessage test timed out waiting for its asynchronous round-trip.

  • Polling window: Extend the test helper’s wait from 4 to 10 seconds.
  • Async continuation: Use ConfigureAwait(false) while polling.
for (var i = 0; i < 500 && !condition(); i++)
{
    await Task.Delay(20).ConfigureAwait(false);
}

Co-authored-by: FlorianRappl <1766191+FlorianRappl@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'windows' Allow more time for cross-origin message delivery tests Nov 6, 2026
Copilot AI requested a review from FlorianRappl November 6, 2026 09:35
Co-authored-by: FlorianRappl <1766191+FlorianRappl@users.noreply.github.com>

@FlorianRappl FlorianRappl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing. I don't think this is a timing issue.

Copilot AI commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Still failing. I don't think this is a timing issue.

You're right—the timeout was not the cause. The queued delivery bypassed EngineInstance.RunTask, so EngineInstance.Current was unset while dispatching the frame's handler; its reply could be posted with the wrong sender context. I routed queued message delivery through the engine runner in 170f94f. The Windows CI job now passes.

@FlorianRappl
FlorianRappl marked this pull request as ready for review November 6, 2026 09:59

@FlorianRappl FlorianRappl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copilot AI requested a review from FlorianRappl November 6, 2026 10:00
@FlorianRappl FlorianRappl added this to the v1.2.0 milestone Nov 6, 2026
@FlorianRappl
FlorianRappl merged commit efb1a4c into devel Nov 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants