Repository navigation
Conversation
Retry require_fresh caller reads only after verified canonical retirement under the original shared bounds. Preserve actual watcher wait across attempts and cover registered raw/facade retirement and refusal controls. Close owned fixture indexers and retain early source-read evidence. Refs #1016.
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retain the bounded checked-retirement correction for fresh
get_callers, and capture unresolved first-attempt failures in the existing shared-file 4 Hz and ordinary canonical-retirement fixtures. This PR is not ready to merge while that correctness failure remains unresolved.The original stable-edit regression could wait for an acknowledged edit, compute correct caller edges, then refuse when the same projection was normally retired into the canonical graph during response decoration. Its correction permits one complete rebound after verified canonical retirement under the original caller deadline and the same 150 ms projection window, started after the initial wait. Physical replacements, source events, unknown owners and exhausted deadlines still refuse.
Refs #1016; this does not close its remaining release acceptance criteria.
Unresolved hosted evidence
The required Ubuntu MCP job ultimately reports success, but its first
mcp-25batch failed the unchanged functional testTestSharedFileOwnReceiptsReachExactRelationsAtFourEditsPerSecond: loaded stream0/edit2 and stream1/edit2 both receivedget_callerserrors,projection not published: superseded. The batch subsequently passed when rerun alone. That later success does not replace either failed first response. Related earlier PR logs also retained this semantic failure before rerun-green results.The original envelopes do not identify the refusing predicate or prove whether it was checked canonical retirement, a newer physical owner, a source event, or an exhausted request allowance. Later non-atomic snapshots and a
fresh=truebarrier rider do not establish final projection acceptance. Local diagnostic passes did not reproduce the refusal and do not explain or exonerate it. This is a functional first-response failure, independent of the separate numerical 3x criterion.Prospective observation result
The instrumented Ubuntu MCP job preserves the original four-worker, prescribed-race, atomic-coverage context and the 4,782-name / 32-batch census. Its final rollup is green, but two first-attempt batches failed and later passed on automatic batch rerun:
mcp-25, all 32get_callersfirst replies were non-error and contained the exact own edge. The unchanged own-impact oracle failed for loaded stream0/edit4: the impact response was a non-error, truthfully labelled pending partial after a 248 ms barrier wait, with zero own depth-1 matches. The oracle already permitscomplete:falsewhen pending and the own match remains present; the missing match is the failing condition. The unflagged impact API permits partial coverage after its default 250 ms wait. This is an explicit request-contract/method question, not evidence of a false-fresh reply or proven producer data loss.mcp-19,TestRegisteredCallersProjectionTransitionBoundary/raw/canonical_retirementreturnedsupersededafter one leaf call and failed its required positive assertion. Its earlier callback deadline check passed, but no actual recovery-time guard/budget record was enabled there. Two budget-expiry records in other successful caller replies do not explain this failure.Neither rerun-green result clears the first failure. The previous caller-refusal event was not reproduced by this observation and is not retroactively explained. A separate private ordinary-boundary capture candidate has passed its controls and original fixture in both modes; it has not been pushed in this head. No further CI retry, impact-argument change, merge, or RC action follows automatically.
Observation changes
UNOBSERVED; no extra owner lookup, source read, stat, registry lock, retry permission or deadline is introduced.Validation of this update
go vetpassed in default and acceptance modes; pinned golangci-lint2.14.0 reported zero issues in both modes.gofmt -s; whitespace, unchanged-module identity and module verification passed.The focused validation checks diagnostic behavior and preserves the original fresh/physical-refusal contracts; it is not another local 4 Hz replay or full-suite qualification. The earlier R20 default diagnostic compiled and passed its three controls plus all 32 first responses without a refusal, which remains inconclusive for the hosted failure.
Retained correctness validation and limits
The original correction retained actual watcher-wait time across attempts, covered registered raw/facade late retirement with real SQLite publication, and preserved physical-change, source-event, cancellation and deadline refusals. Fixture-owned indexers are closed, and early source-read replies are retained without changing extractor-entry, acknowledged-byte, first-response or deadline assertions.
Earlier default MCP coverage accounts for all 4,782 roots: 4,779 root passes, three explicit root skips, and 9,688 named passes including subtests. It combines retained completed roots with a failed/unrun-only continuation after an operator's temporary path exceeded Darwin's Unix-socket limit; that setup failure remains retained. Acceptance had 50 named passes/no skips; the real watcher first reply was fresh with its own edge and positive actual wait in both modes. A mechanical lint-only switch had 11 affected named passes per mode with an exact inverse to previously validated assertion bytes. These are source-qualified historical checks, not a claim that the new hosted observation or all first CI attempts are clean.
An earlier two-second extractor-entry timeout remains unattributed. Isolated and faithful-prefix comparisons passed on both fixed and parent sources without replacing that failure with a retry-green claim. A separate retained-admission control proves a resource precondition, not the timeout's cause. Existing skips cover a no-longer-tight localization fixture, a Windows-only path distinction, unavailable case-distinct directories, and five unsupported analyzer-kind subcases. An overbroad whole-tree formatting read reported 101 unchanged base files; no unrelated formatting cleanup is included.
No benchmark/performance acceptance, product merge, RC tag, or release action is claimed. Product merge and RC remain blocked pending correctness disposition.