Repository navigation
Conversation
Branch protection reads a required check from the newest check suite of the workflow that reports it. An edited/labeled run of CI skipped the Rust jobs, so its newer suite hid "Rust (stable) / Quality" and release PRs stayed blocked until closed and reopened. CI now runs only on code events; the title- and label-sensitive Public API compatibility check moves to its own workflow, which runs completely on every event.
A title edit and a label change sent in one request start two runs in the same second. Concurrency cancelled the run with the newer check suite, and that cancelled result blocked the merge although the older run passed. Each run now completes.
Contributor
Author
|
Metadata-event test on this PR (all edits made after CI passed):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release PR #635 stayed
BLOCKEDwithRequired status check "Rust (stable) / Quality" is expectedalthough theopened/synchronizeCI run passed. Theedited/labeledrun of the sameCIworkflow (concurrency suffixmeta) skipped the Rust jobs, and its check suite was the newest one for the head commit. That suite reported only a skippedRust (${{ matrix.toolchain }}), notRust (stable) / Quality. Re-running the older run did not help; closing and reopening the PR did, because it created a newer complete suite.Change
CIruns only onopened,synchronize,reopened, and pushes tomain. A title, body, or label change no longer creates a newerCIsuite, so it cannot hide or cancel the Rust results.Public API compatibility, the only check that reads the PR title and labels, moves unchanged intopublic-api.yml. That workflow keeps theedited/labeled/unlabeledtriggers and runs the complete check on every event. It has no concurrency group: two metadata events sent in one request start runs in the same second, and a cancelled run could become the newest result and block the merge (observed on this PR at93d9199). Every run therefore completes and is a full result for the current head and metadata.mainruleset and the release-plzrequired-check-runsgate (which looks up check runs by name on the commit) need no change.Verification
actionlintpasses on both workflows.CIrun, everyPublic API compatibilityrun completed, and the PR stayedCLEAN(details in a comment below).