Skip to content

ci: keep title and label events out of the CI workflow - #637

Open
e54-bot wants to merge 2 commits into
mainfrom
ci/split-pr-metadata-checks
Open

e54-bot wants to merge 2 commits into
mainfrom
ci/split-pr-metadata-checks

Conversation

@e54-bot

@e54-bot e54-bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Release PR #635 stayed BLOCKED with Required status check "Rust (stable) / Quality" is expected although the opened/synchronize CI run passed. The edited/labeled run of the same CI workflow (concurrency suffix meta) skipped the Rust jobs, and its check suite was the newest one for the head commit. That suite reported only a skipped Rust (${{ matrix.toolchain }}), not Rust (stable) / Quality. Re-running the older run did not help; closing and reopening the PR did, because it created a newer complete suite.

Change

  • CI runs only on opened, synchronize, reopened, and pushes to main. A title, body, or label change no longer creates a newer CI suite, so it cannot hide or cancel the Rust results.
  • Public API compatibility, the only check that reads the PR title and labels, moves unchanged into public-api.yml. That workflow keeps the edited/labeled/unlabeled triggers and runs the complete check on every event. It has no concurrency group: two metadata events sent in one request start runs in the same second, and a cancelled run could become the newest result and block the merge (observed on this PR at 93d9199). Every run therefore completes and is a full result for the current head and metadata.
  • Check names stay the same, so the main ruleset and the release-plz required-check-runs gate (which looks up check runs by name on the commit) need no change.

Verification

  • actionlint passes on both workflows.
  • Label and title edits on this PR after CI passed: no new CI run, every Public API compatibility run completed, and the PR stayed CLEAN (details in a comment below).

Branch protection reads a required check from the newest check suite of the workflow that reports it. An edited/labeled run of CI skipped the Rust jobs, so its newer suite hid "Rust (stable) / Quality" and release PRs stayed blocked until closed and reopened. CI now runs only on code events; the title- and label-sensitive Public API compatibility check moves to its own workflow, which runs completely on every event.
@e54-bot
e54-bot requested a review from Teakowa as a code owner November 18, 2026 12:58
@e54-bot e54-bot added the github_actions Pull requests that update GitHub Actions code label Nov 18, 2026
@e54-bot e54-bot changed the title ci: keep title and label events out of the CI workflow ci: keep title and label events out of the CI workflow run Nov 18, 2026
@e54-bot e54-bot removed the github_actions Pull requests that update GitHub Actions code label Nov 18, 2026
@e54-bot e54-bot changed the title ci: keep title and label events out of the CI workflow run ci: keep title and label events out of the CI workflow Nov 18, 2026
A title edit and a label change sent in one request start two runs in the same second. Concurrency cancelled the run with the newer check suite, and that cancelled result blocked the merge although the older run passed. Each run now completes.
@e54-bot e54-bot changed the title ci: keep title and label events out of the CI workflow ci: keep title and label events out of CI (test) Nov 18, 2026
@e54-bot e54-bot added the github_actions Pull requests that update GitHub Actions code label Nov 18, 2026
@e54-bot e54-bot changed the title ci: keep title and label events out of CI (test) ci: keep title and label events out of the CI workflow Nov 18, 2026
@e54-bot e54-bot removed the github_actions Pull requests that update GitHub Actions code label Nov 18, 2026
@e54-bot

e54-bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Metadata-event test on this PR (all edits made after CI passed):

  • At 93d9199, a separate label event and title edit: no new CI run; mergeStateStatus stayed CLEAN, with Rust (stable) / Quality from the code-event CI suite and Public API compatibility from the newest metadata run.
  • At 93d9199, one gh pr edit that removed a label and edited the title: the two runs started in the same second, concurrency cancelled the one with the newer check suite (119943645548), and the PR became BLOCKED although the older run passed. 5fbc595 removes the concurrency group from public-api.yml.
  • At 5fbc595, two gh pr edit calls that each changed a label and the title: four Public API compatibility runs, all success, none cancelled; still only the one synchronize CI run; mergeStateStatus CLEAN.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants