Repository navigation
Conversation
|
NOT VERIFIED on head
Verified otherwise:
|
ecb7ea2 to
dd99684
Compare
|
NOT VERIFIED on head
Checked and holding:
|
…lement x[i] = x[i].exclude(v) recompiles to the Modify-at-index form. Refs #744
|
NOT VERIFIED on head
Checked and holding:
|
|
Closing after three review rounds that each found a distinct defect in the self-reference guard (text comparison of rendered operand and target). The Issue is redone from scratch in a new PR that compares structurally and carries the review findings as input. Refs #744. |
Refs #724
Refs #744
Change
convert --target opynow reconstructs these value calls (inreconstruct/value_literals.rs):attacker,victim,healer,healee(no arguments) as the bare OPY keyword;removeFromArray(array, value)as(array).exclude(value).A Set whose
removeFromArrayoperand is its own target (Set Global Variable(g, Remove From Array(g, v))) is refused withunsupported-value-callnamingremoveFromArray:g = g.exclude(v)recompiles to the Modify form, so it cannot round-trip.Tests in
tests/reconstruction_value_calls.rs: OPY round trips in en-US and zh-CN, and the self-referential Set form given as Workshop text (global and player variable) in en-US and zh-CN, which fails on main. The recordedmysteryUltimatesclassification dropsunsupported-value-call.Reproduction (wright 0.44.0)
attacker,victim,removeFromArray: refused, reproduced; fixed here.array: fixed on main by fix: reconstruct array and workshop setting value calls in convert --target opy #748.__ambiguous_enum: enum-domain case, fixed on main by the merged fix: reconstruct enum-domain arguments in convert --target opy #746 change.Validation
fmt, clippy (stable and 1.88.0,
-D warnings),cargo test --workspace --all-targets --all-features,tools/overpy/tests,run_oracle.py,run_native.py: all pass after rebase on origin/main.