Repository navigation
fix: pin String Slice on a Number and point catalog-validation at the call - #757
Merged
Merged
Conversation
Bump workshop-rs to 1.29.2, which gives a span-less validation error the span of its nearest mapped ancestor.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes the remaining scope of #731.
synthetic/string-slice-number: the Issue's reproducer,s = (t % 60 + 100).substring(1, 2). Itsoracle.jsoncomes from the pinned OverPy 9.7.17 (run_oracle.py --update), and the compiler test compares canonical WIR (semantic-wir). It compiles since workshop-rs 1.29.0 accepts the client-verified Number forms (feat(catalog): accept client-verified String Slice and Square Root argument forms workshop-rs#627).catalog-validationerror on a nested value now points at the nearest mapped ancestor instead of1:1. New testa_rejected_nested_argument_points_at_its_callchecks thatvect(1, 2, 3).substring(1, 2)is reported at the call (4:9).Verification
None) and passes on 1.29.2.cargo fmt --check,cargo clippy --workspace --all-targets -D warnings,cargo test --workspace(851 passed).run_native.py: 208 fixtures, 192 match, 16 known gaps (unchanged);python3 -m unittest discover -s tools/overpy/testspasses.Fixes #731