You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: prune resolved entries from LESSONS.md - #151
Prunes resolved entries from docs/LESSONS.md under the merged-pr-retro pruning rule. Four of five entries are removed. The first entry is kept because its prevention home is not in place.
A behavior change updates every document that states the behavior.Escalation: five recurring defect classes from merged PRs (2026-10-25 → 2026-10-26) #126 decided "no new rule now". The prevention home (one home document per claim) was not adopted, so it is not in place. The class is not obsolete. Removing it would drop an open class without a prevention home. The second commit rewrites its prevention line to state the athena#126 outcome.
Verification
git diff --check passes.
Only docs/LESSONS.md changes. The change removes 24 lines.
Finding: the kept entry still tells the reader to "decide in athena#126". The decision is closed.
Location: docs/LESSONS.md, entry "A behavior change updates every document that states the behavior", line Prevention home: owner contract — decide in [athena#126](...) whether each claim gets one home document....
Why it matters: Escalation: five recurring defect classes from merged PRs (2026-10-25 → 2026-10-26) #126 closed on 2026-11-03 with "1. Stale restated documents: no new rule now." The file now points a maintainer at a decision that has been made. The pruning rule (merged-pr-retro, "Do not exceed what a maintainer reads in a minute") needs surviving entries to be accurate. The PR body admits the wording is stale and defers it to "the owner". Issue Prune resolved entries from docs/LESSONS.md #150 scopes LESSONS.md only, so this edit is in scope.
Required change: rewrite that one line to state the outcome. Example: **Prevention home:** none yet. The owner decided in [athena#126](...) on 2026-11-03: no new rule now. Revisit if the class recurs. Change nothing else in the entry.
Keep decision: correct. The rule says "Remove an entry when its rule has been promoted into the prevention home or the class is obsolete." For class 1, #126 chose "no new rule now". No rule was promoted, and the class is not obsolete (7 incidents). Classes 4 and 5 differ: #126 named an existing home (docs/architecture.md modeled/not-modeled rule; engineering-quality.md "Hold the change on the whole path"), and both exist. Pruning class 1 would drop the review queue item with no home. Issue #150's acceptance ("no entry whose prevention home is decided and in place") is met by keeping it, because no home was decided for class 1. The "every entry is resolved" sentence in the Issue body does not override that.
Evidence
Head 4fa58981c8d3. Diff touches only docs/LESSONS.md (-24). Header and file kept.
crates/athena-sim/tests/scenario_schema.rs:155explicit_null_on_an_optional_structured_field_is_refused exists on origin/main.
crates/athena-sim/tests/enum_reads.rs:86every_enum_valued_read_equals_its_enum_literal exists on origin/main.
docs/architecture.md line 50 states unimplemented actions and values are reported as not modeled, never skipped. .github/docs/engineering-quality.md has ## Hold the change on the whole path (line 122).
Changed: rewrote the Prevention home line of the kept entry in docs/LESSONS.md (commit a87ee1a). It now reads: none yet, the owner decided no new rule in athena#126 (2026-11-03), revisit if the class recurs. The PR body no longer defers this to the owner. New head SHA: a87ee1a.
Reviewed head a87ee1ace143b5e2fd4c6b6dc0b14adc9886a623.
Round 1 finding fixed: the kept entry's prevention line now reads "none yet — the owner decided no new rule in athena#126 (2026-11-03); revisit if the class recurs." No other line of that entry changed.
Scope: git diff --stat origin/main HEAD shows only docs/LESSONS.md (1 insertion, 25 deletions, net -24, matching the PR body). git diff --check is clean. Header and file kept.
PR body matches the head: it states the second commit rewrites the prevention line.
Checks: Detect changes passes. Rust Quality, Core builds for WebAssembly and Workflow lint show "skipping" for this docs-only change. No check failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prunes resolved entries from
docs/LESSONS.mdunder themerged-pr-retropruning rule. Four of five entries are removed. The first entry is kept because its prevention home is not in place.Removed
null. Prevention is a test. The test landed in Test explicit null on every optional scenario object field #141 (PR test(scenario): refuse explicit null on every optional object field #146).crates/athena-sim/tests/scenario_schema.rshasexplicit_null_on_an_optional_structured_field_is_refused.crates/athena-sim/tests/enum_reads.rshasevery_enum_valued_read_equals_its_enum_literal.not_modeled. Prevention is the owner contract indocs/architecture.md. The owner decided in Escalation: five recurring defect classes from merged PRs (2026-10-25 → 2026-10-26) #126 that no new action is needed. The contract is already in place.engineering-quality.md"Hold the change on the whole path". The owner decided in Escalation: five recurring defect classes from merged PRs (2026-10-25 → 2026-10-26) #126 that no new action is needed. The policy is already in place.Kept
Verification
git diff --checkpasses.docs/LESSONS.mdchanges. The change removes 24 lines.Fixes #150